Tryton - Issues

 

Issue3797

Title Unify purchase description and use the one of supplier if exists
Priority feature Status in-progress
Superseder Nosy List bvo, ced, jesteve, kstenger, nblock, resteve, risto3
Type behavior Components purchase, stock_supply
Assigned To ced Keywords review
Reviews 4681002,13761002,10671002
View: 4681002, 13761002, 10671002

Created on 2014-03-26.08:31:27 by resteve, last changed by kstenger.

Files
File name Uploaded Type Edit Remove
Screenshot-Ligne d'achat-1.png risto3, 2014-12-06.18:59:04 image/png
Messages
msg22202 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2015-08-24.22:54:54
Not I don't have the time to implement msg19147. Feel free to work on it.
msg22201 (view) Author: [hidden] (risto3) Date: 2015-08-24.19:59:03
Is there any further progress on this issue?
msg19176 (view) Author: [hidden] (resteve) Date: 2014-12-10.11:12:36
If in product.line we have a new m2o field to purchase.product.supplier, I think we could obtain information different to show in reports:

* Internal company reports: use product field
* Supplier reports: use product_supplier field to obtain codes and name from supplier.
msg19147 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-12-06.19:14:59
OK, I think we should change the logic of the patch.
We could add a new field "product supplier" on purchase line. If a value is set on this new field, the product is filled with the linked product if only one exist or limited by a domain.
I think it is cleaner design because it lets the user decide which kind of search he wants.
msg19146 (view) Author: [hidden] (risto3) Date: 2014-12-06.18:59:04
Well, I do have an observation (and a screenshot to demonstrate)

While typing the supplier code, the tips still display the non-supplier code/description.  This is a bit disturbing in reality.

The initial example provided below with 1234 or S1234 is relatively simple, but to demonstrate I have supplier specific codes such as 6001A12 and 6001A14 for company codes 1ACU12 and 1ACU14 respectfully.

Typing '6001' should display all the supplier specific codes for '6001...'
not the company codes.

PM: the product database including suppliers codes is many thousands of entries.

Do I understand the patch correctly that the supplier-specific codes are searched in the 'OR' domain statement after the company-specific codes/description?  (notwithstanding database sql optimisation)
If so, this can be quite brutal, perhaps some additional logic should be put in.

For example, a button to "limit" searches to supplier codes (probably on by default or at least configurable). That is, in absence of a supplier code for a quote, the supplier response typically includes their specific code allowing it to be added prior to confirming the PO for action.

Also, perhaps it would help to configure a minimal number of characters typed in prior to the tip search to avoid sluggish response (we suffered this already in oerp).  

Perhaps this last one should have a new issue created.
msg19139 (view) Author: [hidden] (risto3) Date: 2014-12-06.18:13:53
Okay, I'm testing now... seems that download [raw] didn't pick up the two updated diffs... perhaps an anomalie of sorts
msg19138 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-12-06.17:31:05
Are you sure to test the last patch because the code is there: http://codereview.tryton.org/10671002/diff/20001/product.py#newcode172
msg19137 (view) Author: [hidden] (risto3) Date: 2014-12-06.17:01:38
I confirm that patch works setting the PO to "display" the supplier code/description, but I still am not able to select the product with the suppliers code during entry.
msg19136 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-12-06.16:21:56
Done last review
msg19131 (view) Author: [hidden] (risto3) Date: 2014-12-05.18:33:58
jumping in here... this is great so far.

There is one more use case, when we enter an existing [paper] purchase order.

Frequently we recreating manual PO's from supplier delivery orders with a reference and attachment of the paper PO.

It should be possible to enter the supplier code to select the product as well.

This case happens quite frequently, notably when at the suppliers counter for various parts and materials for construction.
msg19071 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2014-12-03.13:41:20
I reworked this issue into a better behaviour of the description of purchase line.
It should be the one from the supplier if possible.
The review13761002 and review10671002 implement this.
msg16317 (view) Author: [hidden] (resteve) Date: 2014-03-27.08:52:06
I like to explain what is wrong to add "name" in description line and not "rec
name".

Scenario:

1- Create a purchase order
2- Create a new line.
3- Select a product. When select a product on change description line: "[code]
product name"

It's same a sale order, etc...

Scenario purchase request:

1- Select purchase request and do a purchase order.
2- Wizard generate a purchase order with selected purchase request.

Lines in purchase order, description value is "product name". No add "[code]
product name". It's missign code field (generated with rec_name)

IMHO, when generate purchase order manual or purchase request, two ways to
generate a purchase is different info about description line.

My first codereview was fix description line on purchase order lines: "[code]
product name" (rec_name)

Albert comment about description line from supplier product. I'm agree because
some companies don't have same product name that supplier product. An example:

My product:
* Code: 1234
* Name: Product A

My product suplier:
* Code: S1234
* Name: Supplier Product A

If you generate purchase request, description line is "[1234] Product A". When
you send your purchase order to supplier, don't know what product is "[1234]
Product A". It's better add in description line supplier product: "[S1234]
Supplier Product A"

I hope you now understand about need to fix about description line

Thanks
msg16314 (view) Author: [hidden] (resteve) Date: 2014-03-26.08:31:26
Product name in stock supply use name and not rec_name attribute. 

Default product name is "code + name". It's necessary use rec_name attribute.

review4681002
History
Date User Action Args
2017-05-10 23:25:21kstengersetnosy: + kstenger
2016-08-26 10:58:29nblocksetnosy: + nblock
2016-06-28 15:39:11cedlinkissue3680 superseder
2015-08-24 22:54:55cedsetmessages: + msg22202
2015-08-24 19:59:04risto3setmessages: + msg22201
2015-01-20 10:15:22bvosetnosy: + bvo
2015-01-20 09:17:11cedlinkissue4251 superseder
2014-12-10 11:12:36restevesetmessages: + msg19176
2014-12-06 19:14:59cedsetstatus: testing -> in-progress
messages: + msg19147
2014-12-06 18:59:05risto3setfiles: + Screenshot-Ligne d'achat-1.png
messages: + msg19146

Showing 10 items. Show all history (warning: this could be VERY long)