Avoid empty moves on stock accounting

Currently when moving an empty quantity or a product with zero cost price Tryton creates a stock move to track it's valuation with a single line of 0 debit and 0 credit.

I propose to do not create this moves as they do not include any valuable information on the accounting entries of the company.

assigned to @pokoli

added accounting type::feature + 1 deleted label

added 1 deleted label and removed 1 deleted label

review343351002 updated at https://codereview.tryton.org/343351002/#ps330081002

I do not like the idea. For me it will make extension more difficult and it will create special case for almost no benefit.

El 7/1/21 a les 15:00, Cédric Krier ha escrit:

For me it will make extension more difficult and it will create special case for almost no benefit.

Why it will make extension more difficult? The method already returns empty values for several cases, so adding another case does not change anything.

The benefit is having a simpler view on accounting. Taking in account that Tyton sets quantity to zero when doing a partial shipment, this creates an empty stock move for each product that has not been shipped. This can be a high amount of moves in some cases which produce a lot noise to search for the proper values on accounting.

Did you have any use case where this moves are useful?

review343351002 updated at https://codereview.tryton.org/343351002/#ps330091002

Why it will make extension more difficult?

Because extending code must then always test the returned value.

The method already returns empty values for several cases, so adding another case does not change anything.

Indeed this seems not avoidable.

Did you have any use case where this moves are useful?

I may see that it could be useful to check that the period is still open. But I do not know a use case for that.

So why not if anyone has objection.

review343351002 updated at https://codereview.tryton.org/343351002/#ps333741002

New changeset dd70a5b63cbb by Sergi Almacellas Abellana in branch 'default':
Do not create moves with a single empty line
https://hg.tryton.org/modules/account_stock_continental/rev/dd70a5b63cbb

added 1 deleted label and removed 1 deleted label

closed

New changeset 045ba7f46b15 by Sergi Almacellas Abellana in branch 'default':
Do not create moves with a single empty line
https://hg.tryton.org/tryton-env/rev/045ba7f46b15