Issue 9981

Title
Avoid empty moves on stock accounting
Priority
feature
Status
resolved
Nosy list
ced, pokoli, reviewbot, roundup-bot
Assigned to
pokoli
Keywords
review

Created on 2021-01-07.14:46:14 by pokoli, last changed 2 months ago by roundup-bot.

Messages

New changeset 045ba7f46b15 by Sergi Almacellas Abellana in branch 'default':
Do not create moves with a single empty line
https://hg.tryton.org/tryton-env/rev/045ba7f46b15
New changeset dd70a5b63cbb by Sergi Almacellas Abellana in branch 'default':
Do not create moves with a single empty line
https://hg.tryton.org/modules/account_stock_continental/rev/dd70a5b63cbb
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-01-26.22:05:40

Why it will make extension more difficult?

Because extending code must then always test the returned value.

The method already returns empty values for several cases, so adding another case does not change anything.

Indeed this seems not avoidable.

Did you have any use case where this moves are useful?

I may see that it could be useful to check that the period is still open. But I do not know a use case for that.

So why not if anyone has objection.

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-01-07.15:13:16

El 7/1/21 a les 15:00, C├ędric Krier ha escrit:

For me it will make extension more difficult and it will create special case for almost no benefit.

Why it will make extension more difficult?
The method already returns empty values for several cases, so adding another case does not change anything.

The benefit is having a simpler view on accounting. Taking in account that Tyton sets quantity to zero when doing a partial shipment, this creates an empty stock move for each product that has not been shipped. This can be a high amount of moves in some cases which produce a lot noise to search for the proper values on accounting.

Did you have any use case where this moves are useful?

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-01-07.15:00:03

I do not like the idea. For me it will make extension more difficult and it will create special case for almost no benefit.

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-01-07.14:46:13

Currently when moving an empty quantity or a product with zero cost price Tryton creates a stock move to track it's valuation with a single line of 0 debit and 0 credit.

I propose to do not create this moves as they do not include any valuable information on the accounting entries of the company.

History
Date User Action Args
2021-02-15 14:04:12roundup-botsetmessages: + msg64605
2021-02-15 14:04:09roundup-botsetmessages: + msg64604
nosy: + roundup-bot
status: testing -> resolved
2021-01-28 11:18:55reviewbotsetmessages: + msg64130
2021-01-26 22:05:40cedsetmessages: + msg64115
2021-01-07 16:55:42reviewbotsetmessages: + msg63809
2021-01-07 15:13:16pokolisetmessages: + msg63805
2021-01-07 15:00:03cedsetmessages: + msg63804
nosy: + ced
2021-01-07 14:55:04reviewbotsetmessages: + msg63803
nosy: + reviewbot
2021-01-07 14:47:28pokolisetkeyword: + review
reviews: 343351002
status: in-progress -> testing
2021-01-07 14:46:14pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)