Group models for access and rule check

Following https://discuss.tryton.org/t/group-models-for-access-and-rule-check/789

assigned to @ced

added trytond type::feature + 1 deleted label

added 1 deleted label and removed 1 deleted label

review324601002 updated at https://codereview.tryton.org/324601002/#ps302761002

I have a concern about this issue: Currently the system administrator can manage all the access without reading the code but with this new feature it is not possible for a system administrator to know that there is no need to create an access for the invoice lines because they one's from the invoice field are used.

I'm wondering if we should add some field on the user interface to denote this fact.

On 2020-12-02 09:38, Sergi Almacellas Abellana wrote:
> I have a concern about this issue: Currently the system administrator can manage all the access without reading the code but with this new feature it is not possible for a system administrator to know that there is no need to create an access for the invoice lines because they one's from the invoice field are used.

That is not a problem. He will create two rules but the result will be
the same.

> I'm wondering if we should add some field on the user interface to denote this fact.

We could add a flag the fields that are used to delegate access right.

El 2/12/20 a les 10:29, Cédric Krier ha escrit:

I'm wondering if we should add some field on the user interface to denote this fact. We could add a flag the fields that are used to delegate access right.

That makes sense for me but with a proper help text. The idea is that the administrator is aware of it and avoids duplicating access rules.

Last version will require a manual migration:

ALTER TABLE ir_model_field ADD COLUMN "access" BOOLEAN

review324601002 updated at https://codereview.tryton.org/324601002/#ps337161002

review324601002 updated at https://codereview.tryton.org/324601002/#ps331601002

review324601002 updated at https://codereview.tryton.org/324601002/#ps345391003

review324601002 updated at https://codereview.tryton.org/324601002/#ps335551002

review324601002 updated at https://codereview.tryton.org/324601002/#ps331981002

review324601002 updated at https://codereview.tryton.org/324601002/#ps347831002

New changeset 076dc06a541b by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account/rev/076dc06a541b

added 1 deleted label and removed 1 deleted label

closed

New changeset d3da171ed7cd by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account_asset/rev/d3da171ed7cd

New changeset ef79a043773f by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account_invoice/rev/ef79a043773f

New changeset 7ccba40ce46a by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account_payment_braintree/rev/7ccba40ce46a

New changeset d2505410f1cb by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account_payment_stripe/rev/d2505410f1cb

New changeset 430a7a5e8533 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account_statement/rev/430a7a5e8533

New changeset 059eecb4ed0b by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/account_statement_rule/rev/059eecb4ed0b

New changeset 375cc4d05f86 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/bank/rev/375cc4d05f86

New changeset 49d7be2d3bb3 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/commission/rev/49d7be2d3bb3

New changeset ffa8fdc39e28 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/currency/rev/ffa8fdc39e28

New changeset 057f3b4fc9c2 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/product/rev/057f3b4fc9c2

New changeset 3477c5e12fba by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/product_price_list/rev/3477c5e12fba

New changeset 8bf9c09054e9 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/production/rev/8bf9c09054e9

New changeset d325cc11b3ae by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/production_routing/rev/d325cc11b3ae

New changeset e3c9645b2fca by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/purchase/rev/e3c9645b2fca

New changeset e0e10488f91e by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/purchase_amendment/rev/e0e10488f91e

New changeset 25389cebd387 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/purchase_request_quotation/rev/25389cebd387

New changeset 73f57df59401 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/purchase_requisition/rev/73f57df59401

New changeset a56de294eaff by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale/rev/a56de294eaff

New changeset 18f165df5e94 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_advance_payment/rev/18f165df5e94

New changeset 57d53f1b9a10 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_amendment/rev/57d53f1b9a10

New changeset 38d139e86cec by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_complaint/rev/38d139e86cec

New changeset dfdd044c1e98 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_extra/rev/dfdd044c1e98

New changeset 71d0664ed529 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_opportunity/rev/71d0664ed529

New changeset 62212a534fb5 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_product_customer/rev/62212a534fb5

New changeset 489fbd90e747 by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_promotion_coupon/rev/489fbd90e747

New changeset 7ace17d7bdce by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/sale_subscription/rev/7ace17d7bdce

New changeset 96e12f79222b by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/stock/rev/96e12f79222b

New changeset 0ce6d7bd780a by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/modules/stock_forecast/rev/0ce6d7bd780a

New changeset 74f7b0322ede by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/trytond/rev/74f7b0322ede

New changeset 0c071858499a by Cédric Krier in branch 'default':
Add __access__ to Model
https://hg.tryton.org/tryton-env/rev/0c071858499a