Issue 9776
- Title
- Add promotion based on total amount of sale
- Priority
- feature
- Status
- resolved
- Nosy list
- ced, pokoli, reviewbot, roundup-bot
- Assigned to
- ced
- Keywords
- review
Created on 2020-10-30.17:27:34 by ced, last changed 1 month ago by roundup-bot.
Messages
New changeset 9b2ecda2e789 by Cédric Krier in branch 'default': Apply promotion per total amount of sale https://hg.tryton.org/tryton-env/rev/9b2ecda2e789
New changeset 31b3659c68ef by Cédric Krier in branch 'default': Exclude by default shipment cost from promotion amount https://hg.tryton.org/modules/sale_shipment_cost/rev/31b3659c68ef
New changeset 61b33c245877 by Cédric Krier in branch 'default': Apply promotion per total amount of sale https://hg.tryton.org/modules/sale_promotion/rev/61b33c245877
New changeset d1ec80663205 by Cédric Krier in branch 'default': Add TaxableMixin to sale line https://hg.tryton.org/modules/sale/rev/d1ec80663205
I think we could make the amount configurable with a set of checkboxes like "exclude taxes", "exclude shipment cost" etc.
For that I think we can extend get_amount to pass a filter function that will be used to exclude some line in the sum computation.
The amount can be customized so I do not see it as problem. Indeed the problem comes from the imprecision of the natural language. Also the amount set could take care of the shipment cost.
I'm not sure if this is working correctly in some corner case of free shipping. Let me put an example:
- Create a promotion of free shipment over 100€ amount
- Create a carrier with fixed shipment cost of 10€.
- Sale 3 units of a product with unit price of 29€ unit_price and an tax of 10%. (Total amount = 95.70€)
After quoting the sale I get the promotion applied because the sale_shipment_cost of 10€ is included on the total amount of the sale (resulting in an amount over 95.70€). This may be desirable for some promotions but I do not think this is right for free shipment.
So for me, we are missing some way to skip the current line in the amount.
This can be useful for example to setup a free shipping over a specific amount.
The total amount used is the one before any promotion is applied.
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-12-22 00:25:37 | roundup-bot | set | messages: + msg63557 |
| 2020-12-22 00:25:32 | roundup-bot | set | messages: + msg63556 |
| 2020-12-22 00:25:25 | roundup-bot | set | messages: + msg63555 |
| 2020-12-22 00:25:21 | roundup-bot | set | messages:
+ msg63554 nosy: + roundup-bot status: testing -> resolved |
| 2020-12-06 00:32:13 | reviewbot | set | messages: + msg62462 |
| 2020-12-05 23:55:04 | reviewbot | set | messages: + msg62461 |
| 2020-12-05 23:54:59 | reviewbot | set | messages: + msg62460 |
| 2020-12-05 23:54:58 | reviewbot | set | reviews: 314721002,322501006 -> 314721002, 322501006, 326791003 |
| 2020-11-27 22:52:25 | reviewbot | set | messages: + msg62270 |
| 2020-11-27 22:52:22 | reviewbot | set | messages: + msg62269 |
Showing 10 items. Show all history (warning: this could be VERY long)