Domain error when posting a statement with cancelled invoices

Steps to reproduce:

1. Createa a supplier invoice and post it
2. Create an statement with a line to pay the supplier invoice
3. Cancel the invoice
4. Try to post the statement

A domain validation error is raised because the invoice is cancelled before posting.

I think the invoice should be cleared from statement line when cancelling.

added accounting type::behavior + 1 deleted label

I do not agree. For me, the behavior is correct as it warns the user that the statement is no more postable.

added 1 deleted label and removed 1 deleted label

For me the problem is that it warns that there is an invoice which is not valid, but does not explain the error nor which invoice is wrong.

When there are a lot of lines (for example our case had 675 statement lines) it's very hard to find the invoice and fix it.

So if you want to keep the error, we should replace it by an UserError which gives more details.

I proposed to clear the invoice because we already clear posted invoices:

https://hg.tryton.org/modules/account_statement/file/1021ec9c9953/statement.py#l521

So I'm wondering if we should also warn the user when cancelling a posted invoice that is contained in a draft statement.

What do you think?

On 2020-10-16 17:28, Sergi Almacellas Abellana wrote:
> I proposed to clear the invoice because we already clear posted invoices:
>
> https://hg.tryton.org/modules/account_statement/file/1021ec9c9953/statement.py#l521
>
> So I'm wondering if we should also warn the user when cancelling a posted invoice that is contained in a draft statement.
>
> What do you think?

Indeed having the same behavior as for paid invoice will be good as it
warns the user and he will decide.

added easy label

assigned to @acaubet

added 1 deleted label and removed 1 deleted label

New review329371002 at https://codereview.tryton.org/329371002/#ps324371002

review329371002 updated at https://codereview.tryton.org/329371002/#ps329381002

review329371002 updated at https://codereview.tryton.org/329371002/#ps328551002

review329371002 updated at https://codereview.tryton.org/329371002/#ps322401002

review329371002 updated at https://codereview.tryton.org/329371002/#ps328921002

review329371002 updated at https://codereview.tryton.org/329371002/#ps301051002

review329371002 updated at https://codereview.tryton.org/329371002/#ps330051002

review329371002 updated at https://codereview.tryton.org/329371002/#ps337351002

review329371002 updated at https://codereview.tryton.org/329371002/#ps353121002

review329371002 updated at https://codereview.tryton.org/329371002/#ps345351002

review329371002 updated at https://codereview.tryton.org/329371002/#ps347431003

New changeset 90cc8fdb0fd2 by Adrià Tarroja Caubet in branch 'default':
Warn user when posting a statement with canceled or paid lines
https://hg.tryton.org/modules/account_statement/rev/90cc8fdb0fd2