Tryton - Issues

 

Issue9449

Title Send client email via server
Priority feature Status resolved
Superseder Add option to raise error if sendmail fails, Add tools to escape wildcard, Allow keyword action for any model
View: 9456, 9463, 9450
Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components sao, tryton, trytond
Assigned To ced Keywords review
Reviews 292001002
View: 292001002

Created on 2020-06-30.17:29:31 by ced, last changed by roundup-bot.

Messages
New changeset f43b57003e8b by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/tryton-env/rev/f43b57003e8b
New changeset 8288b688cfeb by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/trytond/rev/8288b688cfeb
New changeset 83287ed2d759 by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/tryton/rev/83287ed2d759
New changeset 8e374f951fa2 by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/sao/rev/8e374f951fa2
New changeset 1c5f82e2c528 by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/modules/web_user/rev/1c5f82e2c528
New changeset e454ba88f94c by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/modules/party/rev/e454ba88f94c
New changeset b818ce5257dc by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/modules/notification_email/rev/b818ce5257dc
New changeset 8d9323751b81 by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/modules/company/rev/8d9323751b81
New changeset 2080fa50247b by Cédric Krier in branch 'default':
Send client email via server
https://hg.tryton.org/modules/commission/rev/2080fa50247b
review292001002 updated at https://codereview.tryton.org/292001002/#ps315961002
review292001002 updated at https://codereview.tryton.org/292001002/#ps312281004
review292001002 updated at https://codereview.tryton.org/292001002/#ps310281002
review292001002 updated at https://codereview.tryton.org/292001002/#ps323781002
review292001002 updated at https://codereview.tryton.org/292001002/#ps327761002
review292001002 updated at https://codereview.tryton.org/292001002/#ps306031006
review292001002 updated at https://codereview.tryton.org/292001002/#ps314001070
msg58978 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-07-04.20:52:18
Using sao, when tryting to add a Report to an email template I get the following error:

Traceback (most recent call last):
  File "/trytond/wsgi.py", line 109, in dispatch_request
    return endpoint(request, **request.view_args)
  File "/trytond/protocols/dispatcher.py", line 47, in rpc
    return methods.get(request.rpc_method, _dispatch)(
  File "/trytond/wsgi.py", line 77, in auth_required
    return wrapped(*args, **kwargs)
  File "/trytond/protocols/wrappers.py", line 131, in wrapper
    return func(request, pool, *args, **kwargs)
  File "/trytond/protocols/dispatcher.py", line 181, in _dispatch
    result = rpc.result(meth(*c_args, **c_kwargs))
  File "/trytond/model/modelsql.py", line 1246, in search
    tables, expression = cls.search_domain(domain)
  File "/trytond/model/modelsql.py", line 1432, in search_domain
    expression = convert(domain)
  File "/trytond/model/modelsql.py", line 1429, in convert
    return And((convert(d) for d in (
  File "/trytond/model/modelsql.py", line 1429, in <genexpr>
    return And((convert(d) for d in (
  File "/trytond/model/modelsql.py", line 1420, in convert
    expression = field.convert_domain(domain, tables, cls)
  File "/trytond/model/fields/field.py", line 528, in convert_domain
    return super(FieldTranslate, self).convert_domain(
  File "/trytond/model/fields/field.py", line 391, in convert_domain
    assert name == self.name
AssertionError
review292001002 updated at https://codereview.tryton.org/292001002/#ps317831002
review292001002 updated at https://codereview.tryton.org/292001002/#ps317821002
msg58949 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-07-03.17:04:50
Ready for testing.
review292001002 updated at https://codereview.tryton.org/292001002/#ps292011002
msg58931 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-07-01.23:55:02
On 2020-07-01 23:35, Sergi Almacellas Abellana wrote:
> - Do you plan to allow the user to see all the sent emails for a record? As we have them stored on the server I think it makes sense to allow other users to see all the emails sent for a record (probably with a similar design like attachments and notes).

Yes that's why I created a general relate on all models.

> - Why not sotoring also emails sent by the notification_email module? This will make sense for me to allow the user to see that some notification has sent for the record. Probably we can merge the notification.email.log with the ir.email models and store everything together.

This is something that should be discussed and balanced. But for me, it
is out of the scope of this feature as it would require migration for
notification_email module and this feature is already big enough.
msg58929 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-07-01.23:35:12
I have two doubts here: 

- Do you plan to allow the user to see all the sent emails for a record? As we have them stored on the server I think it makes sense to allow other users to see all the emails sent for a record (probably with a similar design like attachments and notes).

- Why not sotoring also emails sent by the notification_email module? This will make sense for me to allow the user to see that some notification has sent for the record. Probably we can merge the notification.email.log with the ir.email models and store everything together.
review292001002 updated at https://codereview.tryton.org/292001002/#ps305971002
New review292001002 at https://codereview.tryton.org/292001002/#ps317801003
msg58912 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-06-30.17:29:30
Following https://discuss.tryton.org/t/set-up-emails-and-easy-email-delivery/2116/5
History
Date User Action Args
2020-09-17 17:19:07roundup-botsetmessages: + msg60212
2020-09-17 17:18:57roundup-botsetmessages: + msg60211
2020-09-17 17:18:52roundup-botsetmessages: + msg60210
2020-09-17 17:18:50roundup-botsetmessages: + msg60209
2020-09-17 17:18:47roundup-botsetmessages: + msg60208
2020-09-17 17:18:42roundup-botsetmessages: + msg60207
2020-09-17 17:18:36roundup-botsetmessages: + msg60206
2020-09-17 17:18:28roundup-botsetmessages: + msg60205
2020-09-17 17:18:24roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg60204
2020-09-12 15:25:56reviewbotsetmessages: + msg60083

Showing 10 items. Show all history (warning: this could be VERY long)