Tryton - Issues

 

Issue9440

Title Use initial cost price for returned product
Priority feature Status testing
Superseder Wrong cost price computation in drop shipment
View: 9439
Nosy List bernatnan, ced, reviewbot
Type behavior Components product_cost_fifo
Assigned To ced Keywords review
Reviews 327491003
View: 327491003

Created on 2020-06-24.12:22:40 by ced, last changed by reviewbot.

Messages
review327491003 updated at https://codereview.tryton.org/327491003/#ps311881032
msg58878 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-06-25.17:07:41
Better to put LGTM on review.
msg58875 (view) Author: [hidden] (bernatnan) Date: 2020-06-25.15:35:09
LGTM
review327491003 updated at https://codereview.tryton.org/327491003/#ps315661002
review327491003 updated at https://codereview.tryton.org/327491003/#ps325621003
msg58850 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-06-24.12:22:40
For now when a FIFO product is returned, we use the current cost price of this product. So this means that when it will be shipped again, we will use the cost price of the product when it was returned.
This may not be very good especially if the cost price was 0 because there was no product in stock at the moment of return.
Indeed we should use the cost price that was used when the product was shipped. This can be done by using the sale and line origins.
For the exceptional case a returned move is done without being linked to a sale return, we can still use the current cost price. But we should allow to customize this behavior using an extendable method.
History
Date User Action Args
2020-07-14 19:12:48reviewbotsetmessages: + msg59332
2020-06-25 17:07:41cedsetmessages: + msg58878
2020-06-25 15:35:09bernatnansetnosy: + bernatnan
messages: + msg58875
2020-06-25 12:50:56reviewbotsetmessages: + msg58872
2020-06-24 12:30:07reviewbotsetnosy: + reviewbot
messages: + msg58852
2020-06-24 12:26:06cedsetstatus: in-progress -> testing
reviews: 327491003
superseder: + Wrong cost price computation in drop shipment
keyword: + review
2020-06-24 12:22:40cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)