Created on 2020-06-11.15:37:16 by rvong, last changed 3 months ago by roundup-bot.
New changeset a215c2f85492 by Cédric Krier in branch '5.6': Display company in status when main company has children https://hg.tryton.org/modules/company/rev/a215c2f85492
New changeset eaa29d377a03 by Cédric Krier in branch 'default': Display company in status when main company has children https://hg.tryton.org/tryton-env/rev/eaa29d377a03
New changeset 556674c5b075 by Cédric Krier in branch 'default': Display company in status when main company has children https://hg.tryton.org/modules/company/rev/556674c5b075
We can not rely only on the standard module to break the rule that fixing series should not change the feature. The discussion about changing the behavior of the companies field should be done on a feature request.
Regarding the suggestion on not modifying the behavior of res.user's companies field, I have scanned on all modules and found no other additional references/usages, so I don't think there will be any problems. Since I can't find any usage for this field in the existing code, I don't know the original purpose of this field. I assumed that companies field should return the list of companies which the user is associated, so in that case the current implementation is incorrect as it changes based on what the user has as current company. Can anyone provide some insight on this?
I have submitted a patch for code review. I hope I did it correctly.
The company name that is displayed next to the user name is missing in the client status bar when user selects a sub-company among a group of companies with same parent as current company. This issue is present in Trytond version 5.6 and not in earlier versions 5.4. The issue comes from the domain clause used in the "Company.search" from the "res.user.get_companies()" function in the company module. As a solution, the domain clause should be the same as the res.user.company field.
keyword: - backport
|2020-08-03 00:02:08||roundup-bot||set||messages: + msg59590|
|2020-08-03 00:02:04||roundup-bot||set||status: testing -> resolved|
nosy: + roundup-bot
messages: + msg59589
messages: + msg59466
|2020-07-24 10:29:10||ced||set||messages: + msg59465|
|2020-07-24 10:20:49||ced||set||reviews: 327441005 -> 311921002|
assignedto: rvong -> ced
keyword: + backport
nosy: + ced
|2020-06-12 19:06:18||rvong||set||messages: + msg58668|
|2020-06-12 00:19:35||ced||set||status: chatting -> testing|
reviews: https://codereview.tryton.org/327441005/ -> 327441005
|2020-06-11 23:49:02||rvong||set||reviews: https://codereview.tryton.org/327441005/|
status: unread -> chatting
messages: + msg58656
keyword: + review
|2020-06-11 16:19:57||ced||set||keyword: - Python3|
Showing 10 items. Show all history (warning: this could be VERY long)