Tryton - Issues

 

Issue9381

Title Crash when creating purchase from request
Priority bug Status testing
Superseder Nosy List pokoli, reviewbot
Type crash Components sale_supply_drop_shipment
Assigned To pokoli Keywords review
Reviews 317571002
View: 317571002

Created on 2020-06-02.09:12:47 by pokoli, last changed by reviewbot.

Messages
review317571002 updated at https://codereview.tryton.org/317571002/#ps301761002
review317571002 updated at https://codereview.tryton.org/317571002/#ps309811002
review327361002 updated at https://codereview.tryton.org/327361002/#ps317521002
review327361002 updated at https://codereview.tryton.org/327361002/#ps305801002
msg58406 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-06-02.09:12:45
When creating the purchases of two purchase request I get the following exception:

Traceback (most recent call last):
  File "/trytond/wsgi.py", line 109, in dispatch_request
    return endpoint(request, **request.view_args)
  File "/trytond/protocols/dispatcher.py", line 47, in rpc
    return methods.get(request.rpc_method, _dispatch)(
  File "/trytond/wsgi.py", line 77, in auth_required
    return wrapped(*args, **kwargs)
  File "/trytond/protocols/wrappers.py", line 131, in wrapper
    return func(request, pool, *args, **kwargs)
  File "/trytond/protocols/dispatcher.py", line 181, in _dispatch
    result = rpc.result(meth(*c_args, **c_kwargs))
  File "/trytond/wizard/wizard.py", line 295, in execute
    return wizard._execute(state_name)
  File "/trytond/wizard/wizard.py", line 326, in _execute
    result = self._execute(transition())
  File "/trytond/modules/purchase_request/purchase_request.py", line 446, in transition_start
    requests = sorted(requests, key=keyfunc)
TypeError: '<' not supported between instances of 'NoneType' and 'int'

Fault: '<' not supported between instances of 'NoneType' and 'int'

The problem is because one of the purchase request is related to drop_shipment (so it has a customer set) but the other is not.
History
Date User Action Args
2020-06-08 14:36:59reviewbotsetmessages: + msg58610
2020-06-08 13:59:05reviewbotsetmessages: + msg58608
2020-06-08 13:58:08pokolisetreviews: 327361002 -> 317571002
2020-06-02 10:31:23reviewbotsetmessages: + msg58411
2020-06-02 09:38:13reviewbotsetnosy: + reviewbot
messages: + msg58409
2020-06-02 09:13:55pokolisetstatus: in-progress -> testing
reviews: 327361002
keyword: + review
2020-06-02 09:12:47pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)