Adding currency on party

Addition of the currency on parties and use of this information in sales, purchases, invoices and subscriptions if it is fulfilled. Otherwise use of the current currency selection system.

assigned to @2cadz_

added type::feature + 1 deleted label

Take in account that there is also project_invoice which should take care of the party currency.

added 1 deleted label and removed 1 deleted label

In this case it might be interesting to add the concept of currency in the project.

New review290091002 at https://codereview.tryton.org/290091002/#ps295591002

New review307651002 at https://codereview.tryton.org/307651002/#ps305651002

Hi Cristophe,

I've seen you added a new review. But probably there is only one needed. Could you please close the one that is not applicable?

When somebody requests changes you a review you can update it by using the -i flag on the upload.py tool. For example:

upload.py -i

Hi Sergi,

So I misunderstood your previous message, so what do I do? I update the first one and I delete the last one?

Hi Christophe,

Better to update the first one (and remove the new one) so my previous comments on the reviews are keep there.

review290091002 updated at https://codereview.tryton.org/290091002/#ps307661002

review290091002 updated at https://codereview.tryton.org/290091002/#ps297871002

review290091002 updated at https://codereview.tryton.org/290091002/#ps303701002

review290091002 updated at https://codereview.tryton.org/290091002/#ps319701002

I think we should add two currency fields on party. One for supplier side and one for customer side. It can happen that a party is both customer and supplier at the same time and the currency of the supplier side is defined by the supplier but the currency of the customer side is defined by the company that uses tryton.

review290091002 updated at https://codereview.tryton.org/290091002/#ps324671002

I think it should follow the same design as #9855 (closed) for payment term.

So we need to do the following:

• Add customer_currency and supplier_currency to party. Both should be a multivalue
• On sales if the customer has a currency use it otherwise use the currency one
• On purchases override supplier currency overrides the setting for last purchases. If not supplier_currency is set the current behaviour is keep.

Correct me if something is wrong.

@2cadz do you plan to work on this?

@2cadz do you plan to work on this?

Yes, but not until next week

• Add customer_currency and supplier_currency to party. Both should be a multivalue

Where to add these fields ? my first idea was to place them in the 'party' module, but maybe it's better one in the 'sale' module the other in the 'purchase' module, what do you think?