Tryton - Issues

 

Issue9305

Title Adding currency on party
Priority feature Status chatting
Superseder Nosy List 2cadz, pokoli, reviewbot
Type feature request Components
Assigned To 2cadz Keywords review
Reviews 290091002
View: 290091002

Created on 2020-05-06.23:44:49 by 2cadz, last changed by reviewbot.

Messages
review290091002 updated at https://codereview.tryton.org/290091002/#ps303701002
review290091002 updated at https://codereview.tryton.org/290091002/#ps297871002
review290091002 updated at https://codereview.tryton.org/290091002/#ps307661002
msg58211 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-05-22.10:58:28
Hi Christophe,

Better to update the first one (and remove the new one) so my previous comments on the reviews are keep there.
msg58210 (view) Author: [hidden] (2cadz) Date: 2020-05-22.10:53:50
Hi Sergi,

So I misunderstood your previous message, so what do I do? I update the first one and I delete the last one?
msg58209 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-05-22.10:49:18
Hi Cristophe, 

I've seen you added a new review. But probably there is only one needed. Could you please close the one that is not applicable?

When somebody requests changes you a review you can update it by using the -i flag on the upload.py tool. For example:

upload.py -i <review_id>
New review307651002 at https://codereview.tryton.org/307651002/#ps305651002
New review290091002 at https://codereview.tryton.org/290091002/#ps295591002
msg58123 (view) Author: [hidden] (2cadz) Date: 2020-05-19.11:24:08
In this case it might be interesting to add the concept of currency in the project.
msg57861 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-05-07.08:30:59
Take in account that there is also project_invoice which should take care of the party currency.
msg57859 (view) Author: [hidden] (2cadz) Date: 2020-05-06.23:44:48
Addition of the currency on parties and use of this information in sales, purchases, invoices and subscriptions if it is fulfilled. Otherwise use of the current currency selection system.
History
Date User Action Args
2020-05-27 19:04:37reviewbotsetmessages: + msg58330
2020-05-27 17:37:51reviewbotsetmessages: + msg58329
2020-05-22 11:33:30reviewbotsetmessages: + msg58218
2020-05-22 11:28:042cadzsetreviews: 290091002, 307651002 -> 290091002
2020-05-22 10:58:28pokolisetmessages: + msg58211
2020-05-22 10:53:512cadzsetmessages: + msg58210
2020-05-22 10:49:18pokolisetmessages: + msg58209
2020-05-22 10:35:30reviewbotsetmessages: + msg58208
2020-05-22 10:35:30reviewbotsetreviews: 290091002 -> 290091002, 307651002
2020-05-19 16:01:20reviewbotsetnosy: + reviewbot
messages: + msg58131

Showing 10 items. Show all history (warning: this could be VERY long)