Issue 9305

Title
Adding currency on party
Priority
feature
Status
testing
Superseder
Add field access on referential document (issue 10269)
Nosy list
2cadz, Timitos, ced, pokoli, reviewbot
Assigned to
2cadz
Keywords
review

Created on 2020-05-06.23:44:49 by 2cadz, last changed 5 months ago by ced.

Messages

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-04-11.15:01:15

issue10269 should first be implemented.

Author: [hidden] (2cadz)
Date: 2021-04-10.10:26:48

So the currency usage on account_invoice module should be removed to avoid crashing when sale or purchase modules are not activated.

I rather tested the presence of the field and use it if it was there, what do you think?

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-04-08.08:57:21

Makes sense for me. If you have the supplier invoice the currency should be listed there and for customer invoices we use sale module to get the proper values.

So the currency usage on account_invoice module should be removed to avoid crashing when sale or purchase modules are not activated.

Author: [hidden] (2cadz)
Date: 2021-04-08.08:51:59

I think the usage of the currency starts on the invoice (you may have an invoice of a supplier on diferent currency without having the purchase module). So for me it makes sense to define both fields on the account_invoice module and use them on sale, purchase and other modules.

When entering the invoice there is no ambiguity on the currency it is specified. I think the currency issue arises when entering a buy or sell because it is possible to have some doubt. But this is only my opinion, I can move fields very well in the invoices module.

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-04-08.08:39:35

I think the usage of the currency starts on the invoice (you may have an invoice of a supplier on diferent currency without having the purchase module). So for me it makes sense to define both fields on the account_invoice module and use them on sale, purchase and other modules.

This is coherent with the payment_term usage.

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-04-06.18:53:04
On 2021-04-06 18:05, Christophe wrote:
> > * Add customer_currency and supplier_currency to party. Both should be a multivalue
> 
> Where to add these fields ? my first idea was to place them in the 'party' module, but maybe it's better one in the 'sale' module the other in the 'purchase' module, what do you think?

For me each one should be added in the respecting module that uses them,
so probably sale and purchase.
Author: [hidden] (2cadz)
Date: 2021-04-06.18:05:25
  • Add customer_currency and supplier_currency to party. Both should be a multivalue

Where to add these fields ? my first idea was to place them in the 'party' module, but maybe it's better one in the 'sale' module the other in the 'purchase' module, what do you think?

Author: [hidden] (2cadz)
Date: 2021-03-31.07:57:02

@2cadz do you plan to work on this?

Yes, but not until next week

Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2021-03-30.17:01:31

So we need to do the following:

  • Add customer_currency and supplier_currency to party. Both should be a multivalue
  • On sales if the customer has a currency use it otherwise use the currency one
  • On purchases override supplier currency overrides the setting for last purchases. If not supplier_currency is set the current behaviour is keep.

Correct me if something is wrong.

@2cadz do you plan to work on this?

Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2021-03-18.13:02:14

I think it should follow the same design as issue9855 for payment term.

Author: [hidden] (Timitos) Tryton translator
Date: 2020-07-13.15:28:18
I think we should add two currency fields on party. One for supplier side and one for customer side. It can happen that a party is both customer and supplier at the same time and the currency of the supplier side is defined by the supplier but the currency of the customer side is defined by the company that uses tryton.
Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2020-05-22.10:58:28
Hi Christophe,

Better to update the first one (and remove the new one) so my previous comments on the reviews are keep there.
Author: [hidden] (2cadz)
Date: 2020-05-22.10:53:50
Hi Sergi,

So I misunderstood your previous message, so what do I do? I update the first one and I delete the last one?
Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2020-05-22.10:49:18
Hi Cristophe, 

I've seen you added a new review. But probably there is only one needed. Could you please close the one that is not applicable?

When somebody requests changes you a review you can update it by using the -i flag on the upload.py tool. For example:

upload.py -i <review_id>
Author: [hidden] (2cadz)
Date: 2020-05-19.11:24:08
In this case it might be interesting to add the concept of currency in the project.
Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2020-05-07.08:30:59
Take in account that there is also project_invoice which should take care of the party currency.
Author: [hidden] (2cadz)
Date: 2020-05-06.23:44:48
Addition of the currency on parties and use of this information in sales, purchases, invoices and subscriptions if it is fulfilled. Otherwise use of the current currency selection system.
History
Date User Action Args
2021-04-11 15:01:15cedsetmessages: + msg66398
superseder: + Add field access on referential document
2021-04-10 10:26:482cadzsetmessages: + msg66279
2021-04-08 17:22:36reviewbotsetmessages: + msg66185
2021-04-08 08:57:59pokolisetstatus: chatting -> testing
2021-04-08 08:57:21pokolisetmessages: + msg66171
2021-04-08 08:51:592cadzsetmessages: + msg66170
2021-04-08 08:39:35pokolisetmessages: + msg66169
2021-04-08 07:49:08reviewbotsetmessages: + msg66168
2021-04-06 18:53:04cedsetmessages: + msg66142
2021-04-06 18:05:252cadzsetmessages: + msg66141

Showing 10 items. Show all history (warning: this could be VERY long)