Tryton - Issues

 

Issue9164

Title Ensure clearing account is used on statement
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components account_payment_clearing
Assigned To pokoli Keywords review
Reviews 303101006
View: 303101006

Created on 2020-03-17.15:49:50 by pokoli, last changed by roundup-bot.

Messages
New changeset 0661961d8493 by Sergi Almacellas Abellana in branch 'default':
Set clearing account when payment or group is set
https://hg.tryton.org/tryton-env/rev/0661961d8493
New changeset 0a983bf1578f by Sergi Almacellas Abellana in branch 'default':
Set clearing account when payment or group is set
https://hg.tryton.org/modules/account_payment_clearing/rev/0a983bf1578f
msg56315 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-03-17.17:07:59
It is not like invoice because the account and party are used as invoice domain. So it is not possible to set an account with diferent values, so it is only required to update it when empty. 

For me the user values should not be keep in this case as we should ensure that the correct account it's used.
msg56312 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-17.16:22:15
It is the same behavior as for on_change_invoice. I do not know what is the best behavior because usually we avoid changing value that user has encoded.
review303101006 updated at https://codereview.tryton.org/303101006/#ps258981005
msg56309 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-03-17.15:49:49
When setting a payment or a payment group on a statement, if the account is already set it is keep instead of being replaced by the clearing account. 

The clearing account should be always used by default to ensure that the clearing  moves amounts are correctly balanced.
History
Date User Action Args
2020-03-30 09:42:38roundup-botsetmessages: + msg56783
2020-03-30 09:42:33roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg56782
2020-03-28 10:52:55cedlinkissue9145 superseder
2020-03-17 17:08:00pokolisetmessages: + msg56315
2020-03-17 16:22:15cedsetnosy: + ced
messages: + msg56312
2020-03-17 16:04:07reviewbotsetnosy: + reviewbot
messages: + msg56311
2020-03-17 15:51:29pokolisetstatus: in-progress -> testing
reviews: 303101006
keyword: + review
2020-03-17 15:49:50pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)