Tryton - Issues

 

Issue9146

Title Use field digits on secondary unit
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot, smn
Type behavior Components
Assigned To ced Keywords review
Reviews 299521002
View: 299521002

Created on 2020-03-11.09:25:56 by smn, last changed by roundup-bot.

Messages
New changeset 901d9743e923 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/tryton-env/rev/901d9743e923
New changeset 7c0cd2e70d8e by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/stock_secondary_unit/rev/7c0cd2e70d8e
New changeset 8b46722923ab by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/stock_consignment/rev/8b46722923ab
New changeset 406bfa727011 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/stock/rev/406bfa727011
New changeset 52f959701cc3 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/52f959701cc3
New changeset 7ced341ede12 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/sale_subscription/rev/7ced341ede12
New changeset 11cd1c53834a by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/sale_shipment_cost/rev/11cd1c53834a
New changeset 02f5d8d8f1e5 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/sale_secondary_unit/rev/02f5d8d8f1e5
New changeset 9289363b33bd by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/sale_promotion/rev/9289363b33bd
New changeset e68216124bb0 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/sale/rev/e68216124bb0
New changeset 5fb6c24f35b8 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/purchase_shipment_cost/rev/5fb6c24f35b8
New changeset fb0163fff38e by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/purchase_secondary_unit/rev/fb0163fff38e
New changeset 01f27d49d3c7 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/purchase_request/rev/01f27d49d3c7
New changeset d997f6af3995 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/purchase/rev/d997f6af3995
New changeset 7c52341cc482 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/project_revenue/rev/7c52341cc482
New changeset a3b11530ef77 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/production_work/rev/a3b11530ef77
New changeset fc537a2933c4 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/production_outsourcing/rev/fc537a2933c4
New changeset 35afec960bc8 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/production/rev/35afec960bc8
New changeset d72dd8de77d7 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/product_cost_history/rev/d72dd8de77d7
New changeset f9284f46a6f0 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/product_cost_fifo/rev/f9284f46a6f0
New changeset 14439dbd5633 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/product/rev/14439dbd5633
New changeset 4151464e05be by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/commission/rev/4151464e05be
New changeset 601a90d568b5 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/account_stock_landed_cost/rev/601a90d568b5
New changeset 3635678faf96 by Cédric Krier in branch 'default':
Add round_price
https://hg.tryton.org/modules/account_invoice_secondary_unit/rev/3635678faf96
review299521002 updated at https://codereview.tryton.org/299521002/#ps289851002
msg57313 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-19.22:14:06
Here is review299521002
msg56201 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-11.11:33:03
On 2020-03-11 11:10, Sergio wrote:
> And why not add the rounding on existing uom.compute_price method?

Why not but I still think that we need also to round price that are not
the result of Uom.compute_price
msg56200 (view) Author: [hidden] (smn) Date: 2020-03-11.11:10:05
And why not add the rounding on existing uom.compute_price method?
msg56197 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-11.10:10:41
Indeed I think we should not allow/permit to modify fields using price_digits. For integrity, it should be the same digits everywhere.
I think it is better to replace existing old rounding and set on product.py a method to round using price_digits.
New review297211002 at https://codereview.tryton.org/297211002/#ps258961002
msg56194 (view) Author: [hidden] (smn) Date: 2020-03-11.09:25:55
In secondary unit modules when computing secondary unit price or unit price it uses always price_digits instead of digits of field. By default it is the same but if we modify the field definition the computing is wrong.
History
Date User Action Args
2020-04-23 21:46:55roundup-botsetmessages: + msg57403
2020-04-23 21:46:48roundup-botsetmessages: + msg57402
2020-04-23 21:46:40roundup-botsetmessages: + msg57401
2020-04-23 21:46:34roundup-botsetmessages: + msg57400
2020-04-23 21:46:29roundup-botsetmessages: + msg57399
2020-04-23 21:46:24roundup-botsetmessages: + msg57398
2020-04-23 21:46:20roundup-botsetmessages: + msg57397
2020-04-23 21:46:11roundup-botsetmessages: + msg57396
2020-04-23 21:46:06roundup-botsetmessages: + msg57395
2020-04-23 21:46:00roundup-botsetmessages: + msg57394

Showing 10 items. Show all history (warning: this could be VERY long)