Tryton - Issues

 

Issue9146

Title Use field digits on secondary unit
Priority bug Status chatting
Superseder Nosy List ced, reviewbot, smn
Type Components account_invoice_secondary_unit, purchase_secondary_unit, sale_secondary_unit
Assigned To Keywords review
Reviews

Created on 2020-03-11.09:25:56 by smn, last changed by ced.

Messages
msg56201 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-11.11:33:03
On 2020-03-11 11:10, Sergio wrote:
> And why not add the rounding on existing uom.compute_price method?

Why not but I still think that we need also to round price that are not
the result of Uom.compute_price
msg56200 (view) Author: [hidden] (smn) Date: 2020-03-11.11:10:05
And why not add the rounding on existing uom.compute_price method?
msg56197 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-11.10:10:41
Indeed I think we should not allow/permit to modify fields using price_digits. For integrity, it should be the same digits everywhere.
I think it is better to replace existing old rounding and set on product.py a method to round using price_digits.
New review297211002 at https://codereview.tryton.org/297211002/#ps258961002
msg56194 (view) Author: [hidden] (smn) Date: 2020-03-11.09:25:55
In secondary unit modules when computing secondary unit price or unit price it uses always price_digits instead of digits of field. By default it is the same but if we modify the field definition the computing is wrong.
History
Date User Action Args
2020-03-11 11:33:03cedsetmessages: + msg56201
2020-03-11 11:10:05smnsetmessages: + msg56200
2020-03-11 10:12:56smnsetreviews: 297211002 ->
2020-03-11 10:10:41cedsetnosy: + ced
messages: + msg56197
2020-03-11 09:39:59smnsetreviews: 297211002,278771002,293211002 -> 297211002
2020-03-11 09:38:11smnsetreviews: 297211002,278771002 -> 297211002,278771002,293211002
2020-03-11 09:37:48smnsetreviews: 297211002 -> 297211002,278771002
2020-03-11 09:29:46reviewbotsetstatus: unread -> chatting
nosy: + reviewbot
messages: + msg56195
2020-03-11 09:29:45reviewbotsetreviews: 297211002
keyword: + review
2020-03-11 09:25:56smncreate

Showing 10 items. Show all history (warning: this could be VERY long)