Tryton - Issues

 

Issue9059

Title Add symbol widget
Priority feature Status testing
Superseder Nosy List ced, mrichez, pokoli, reviewbot, tbruyere
Type feature request Components tryton
Assigned To mrichez Keywords review
Reviews 276871002, 325141002
View: 276871002, 325141002

Created on 2020-02-12.09:27:43 by mrichez, last changed by reviewbot.

Files
File name Uploaded Type Edit Remove
Capture d’écran du 2020-02-12 09-27-22.png mrichez, 2020-02-12.09:27:43 image/png
Messages
review325141002 updated at https://codereview.tryton.org/325141002/#ps311811002
review325141002 updated at https://codereview.tryton.org/325141002/#ps311771002
review276871002 updated at https://codereview.tryton.org/276871002/#ps317631002
review276871002 updated at https://codereview.tryton.org/276871002/#ps290041002
review325141002 updated at https://codereview.tryton.org/325141002/#ps290031002
msg57415 (view) Author: [hidden] (mrichez) Date: 2020-04-24.12:04:08
Added second issue to apply symbol widget in most of modules concerned
review276871002 updated at https://codereview.tryton.org/276871002/#ps289881002
review276871002 updated at https://codereview.tryton.org/276871002/#ps287051002
review276871002 updated at https://codereview.tryton.org/276871002/#ps307301002
review276871002 updated at https://codereview.tryton.org/276871002/#ps295321002
msg56800 (view) Author: [hidden] (mrichez) Date: 2020-03-30.20:19:24
>* Why the untaxed_amount, taxes_amount and total amount of sale do not include >the currency symbol?
>I think we should also update the following modules to follow the same design: >account, account_asset, account_payment, account_invoice, stock, >sale_subscription, production, project_revenue, *_secondary_unit

Indeed, i add currency/unit symbol on some fields in purchase/sale module for testing purposes.But, before to go on with all modules, i would to know if what i've done in the backend is the correct way and don't imply a lot of changes.
Then, i don't know which fields i could remove from display (treeview/form) in existing models (maybe unit or currency fields should become invisible if all of the fields will have their symbol next their value and so those columns/field become useless for the user... 

>* Do we realy want to show the currency symbol on the unit price? As far as the >amount uses more digits than the currency, i'm not sure if it really makes >sense. Indeed on the report the currency is only shown for the line's amount.
  
Don't know, this enhancement is useful for the user when he is watching a form without the currency/unit field and then price or amount or quantity fields are "meaningless" without the symbol... but i'm hoping some help to tell me where it is useful to add the symbol. Thanks!
msg56797 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-03-30.17:19:16
Thanks for sharing an screenshot. Just some comments about it: 

* Why the untaxed_amount, taxes_amount and total amount of sale do not include the currency symbol?
* Do we realy want to show the currency symbol on the unit price? As far as the amount uses more digits than the currency, i'm not sure if it really makes sense. Indeed on the report the currency is only shown for the line's amount.  

I think we should also update the following modules to follow the same design: account, account_asset, account_payment, account_invoice, stock, sale_subscription, production, project_revenue, *_secondary_unit
review276871002 updated at https://codereview.tryton.org/276871002/#ps307111002
review276871002 updated at https://codereview.tryton.org/276871002/#ps291111002
review276871002 updated at https://codereview.tryton.org/276871002/#ps262991002
review276871002 updated at https://codereview.tryton.org/276871002/#ps274871002
msg55349 (view) Author: [hidden] (mrichez) Date: 2020-02-12.13:42:45
>I also think we should find a way to make unit looks more attached to the entry >as in sao we will use .input-group-addon
Which way? All content is in Gtk.HBox... Should i use a Gtk.Frame?
New review276871002 at https://codereview.tryton.org/276871002/#ps260961006
msg55347 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-12.09:41:16
I also think we should find a way to make unit looks more attached to the entry as in sao we will use .input-group-addon
msg55346 (view) Author: [hidden] (mrichez) Date: 2020-02-12.09:32:46
Need help with the Sao part... this is not working because of asynchronous call and don't know how to solve it. Thanks!
msg55345 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-12.09:31:27
I think we need few space between the widget and the unit.
msg55344 (view) Author: [hidden] (mrichez) Date: 2020-02-12.09:27:43
Following https://discuss.tryton.org/t/displaying-currency-on-line-form/2258/12
This is widget will display the symbol linked to the field in unit attribute of the displayed field.
Example:
<field name="amount" unit="currency"/>
"currency" is M2O field and his model inherit from the UnitMixin
History
Date User Action Args
2020-06-26 16:18:09reviewbotsetmessages: + msg58889
2020-06-15 17:07:58reviewbotsetmessages: + msg58719
2020-06-12 11:35:43reviewbotsetmessages: + msg58657
2020-05-11 13:35:32reviewbotsetmessages: + msg57950
2020-05-11 13:31:38reviewbotsetmessages: + msg57949
2020-04-24 13:06:36mrichezsetreviews: 276871002 -> 276871002, 325141002
2020-04-24 12:04:09mrichezsetmessages: + msg57415
2020-04-22 10:09:12reviewbotsetmessages: + msg57364
2020-04-08 16:04:09reviewbotsetmessages: + msg56942
2020-04-07 15:30:15reviewbotsetmessages: + msg56940

Showing 10 items. Show all history (warning: this could be VERY long)