Tryton - Issues

 

Issue9030

Title clearing move uses today date on statement
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot, semarie
Type behavior Components account_payment_clearing
Assigned To semarie Keywords review
Reviews 253031002
View: 253031002

Created on 2020-02-01.18:01:31 by semarie, last changed by roundup-bot.

Messages
New changeset 12d8c617ecd9 by C├ędric Krier in branch 'default':
Use the date of the statement as date for the clearing move
https://hg.tryton.org/tryton-env/rev/12d8c617ecd9
New changeset 1b86b11c3c2c by Sebastien Marie in branch 'default':
Use the date of the statement as date for the clearing move
https://hg.tryton.org/modules/account_payment_clearing/rev/1b86b11c3c2c
review253031002 updated at https://codereview.tryton.org/253031002/#ps273021003
review253031002 updated at https://codereview.tryton.org/253031002/#ps282961002
review253031002 updated at https://codereview.tryton.org/253031002/#ps256511002
review253031002 updated at https://codereview.tryton.org/253031002/#ps288991002
msg55172 (view) Author: [hidden] (semarie) Date: 2020-02-02.07:00:22
in my case, I am using it while using SEPA payment: I create payment to paying some purchase invoice, next send the XML SEPA file to my bank. Later, when importing daily statement from the bank, I see the payment has been proceed, and I fill the statement line with the payment reference, and validate the statement. So I am already recording the potential delay of the bank: the statement date is the effective date of the payment as the bank did it.

here, the change only affects the payment date when using statement. so I think it covers most of the cases. else it would mean the statement date isn't the date of payment ? I dunno.
review253031002 updated at https://codereview.tryton.org/253031002/#ps282901002
msg55170 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-01.18:15:01
I think it makes sense but I'm wondering if there are no cases where we would like to customize this date (like adding some delay because the financial institute has processing delay).
msg55169 (view) Author: [hidden] (semarie) Date: 2020-02-01.18:01:30
when using a Payment or a PaymentGroup in a StatementLine, when the Statement is validated, the clearing_move is created with today as date, whereas I would expect it to use the StatementLine date (as the move created for the StatementLine)
History
Date User Action Args
2020-03-20 19:10:57roundup-botsetmessages: + msg56557
2020-03-20 19:10:50roundup-botsetstatus: chatting -> resolved
nosy: + roundup-bot
messages: + msg56556
2020-03-06 12:34:51reviewbotsetmessages: + msg56105
2020-02-16 07:47:00reviewbotsetmessages: + msg55390
2020-02-02 10:15:38reviewbotsetmessages: + msg55174
2020-02-02 07:25:15reviewbotsetmessages: + msg55173
2020-02-02 07:00:22semariesetmessages: + msg55172
2020-02-01 18:22:06reviewbotsetnosy: + reviewbot
messages: + msg55171
2020-02-01 18:15:07cedsetpriority: bug -> feature
2020-02-01 18:15:02cedsetstatus: unread -> chatting
nosy: + ced
messages: + msg55170

Showing 10 items. Show all history (warning: this could be VERY long)