Tryton - Issues

 

Issue9020

Title Improve product form with no template
Priority feature Status resolved
Superseder Nosy List ced, jan, mrichez, pokoli, reviewbot, roundup-bot
Type feature request Components product
Assigned To ced Keywords review
Reviews 284751002
View: 284751002

Created on 2020-01-29.23:57:31 by ced, last changed by roundup-bot.

Messages
New changeset 98c018e5d0af by Cédric Krier in branch 'default':
Hide product fields inherited from template when empty
https://hg.tryton.org/tryton-env/rev/98c018e5d0af
New changeset a2a17a55554e by Cédric Krier in branch 'default':
Hide product fields inherited from template when empty
https://hg.tryton.org/modules/product/rev/a2a17a55554e
msg55146 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-30.14:54:36
> I do not think it is doable without a big machinery just for that. Because we can not know in advance if the tab will be empty or not.

Ok, so I think we can live with that just to keep things simple.
msg55141 (view) Author: [hidden] (mrichez) Date: 2020-01-30.14:34:20
Tabs Customs and Measurement are also empty
msg55140 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-30.14:15:48
I do not think it is doable without a big machinery just for that. Because we can not know in advance if the tab will be empty or not.
msg55138 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-30.14:11:22
I've tested it, it looks great but I've just found a minor issues: 

- When the template is not set the accounting tab is shown with no field inside.

It will be great if we can hide it also.
msg55132 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-30.12:26:53
@mrichez check issue9025
msg55122 (view) Author: [hidden] (mrichez) Date: 2020-01-30.10:24:25
I made some tests, behaviour to create template is strange depending if you create template when typing new template in many2one and then doing create, or if you click on search, then doing create when clicking new... it creates a template with an empty code, then you specify your code on the product view of the sale_line and it creates another code... so your template has 2 variants... (empty code and new code)...
msg55121 (view) Author: [hidden] (jan) Date: 2020-01-30.10:12:38
.. or possibly mark them as required until template is choosen and than create a template from this values? So we switch the behavior that creation of a template creates a variant to "creation of a product creates a template if no template choosen"
review284751002 updated at https://codereview.tryton.org/284751002/#ps282871002
msg55116 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-29.23:57:30
Following the discussion on https://discuss.tryton.org/t/merge-products-variants-into-one-database-table-one-view-one-list/2241
One point is that when trying to create a product from an operational document (like sale line), the form is confusing because a template must be set instead of filling the read-only fields "inherited" (which can confused the user).
I propose to hide those read-only fields until a template is selected.
History
Date User Action Args
2020-03-05 00:28:11roundup-botsetmessages: + msg56067
2020-03-05 00:28:05roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg56066
2020-01-30 14:54:36pokolisetmessages: + msg55146
2020-01-30 14:34:20mrichezsetmessages: + msg55141
2020-01-30 14:15:49cedsetmessages: + msg55140
2020-01-30 14:11:22pokolisetnosy: + pokoli
messages: + msg55138
2020-01-30 12:26:53cedsetmessages: + msg55132
2020-01-30 10:24:25mrichezsetnosy: + mrichez
messages: + msg55122
2020-01-30 10:12:38jansetnosy: + jan
messages: + msg55121
2020-01-30 00:17:56reviewbotsetnosy: + reviewbot
messages: + msg55117

Showing 10 items. Show all history (warning: this could be VERY long)