Tryton - Issues

 

Issue9012

Title Prevent drag and drop of event with readonly dates
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components sao, tryton, trytond
Assigned To ced Keywords review
Reviews 256451002
View: 256451002

Created on 2020-01-22.18:37:00 by ced, last changed by roundup-bot.

Messages
New changeset 2e44d43f0def by Cédric Krier in branch 'default':
Manage readonly dates and editable calendar view
https://hg.tryton.org/tryton-env/rev/2e44d43f0def
New changeset da6e03207a48 by Cédric Krier in branch 'default':
Manage readonly dates and editable calendar view
https://hg.tryton.org/trytond/rev/da6e03207a48
New changeset 521d1943fa23 by Cédric Krier in branch 'default':
Manage readonly dates and editable calendar view
https://hg.tryton.org/tryton/rev/521d1943fa23
New changeset 1eee241da577 by Cédric Krier in branch 'default':
Manage readonly dates and editable calendar view
https://hg.tryton.org/sao/rev/1eee241da577
review256451002 updated at https://codereview.tryton.org/256451002/#ps284721008
msg54993 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-22.19:03:24
I have also added the editable attribute on calendar view. If set to 0, it prevents any edition (D&D and double click creation) from the view.
review256451002 updated at https://codereview.tryton.org/256451002/#ps270841002
msg54991 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-22.18:38:44
Here is review256451002, it requires https://goocalendar.tryton.org/bug27 to work properly.
msg54990 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-22.18:36:59
As using drag and drop on calendar view means editing the start and/or end date. I think the drag and drop should be deactivated if any of those dates are readonly (and if user has no write access on the model).
The model access should also be checked for creation on tryton as it is on sao.
History
Date User Action Args
2020-02-29 23:44:22roundup-botsetmessages: + msg55659
2020-02-29 23:44:17roundup-botsetmessages: + msg55658
2020-02-29 23:44:13roundup-botsetmessages: + msg55657
2020-02-29 23:44:09roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg55656
2020-01-22 19:17:00reviewbotsetnosy: + reviewbot
messages: + msg54994
2020-01-22 19:03:25cedsetnosy: - reviewbot
component: + trytond
messages: + msg54993
2020-01-22 18:53:11reviewbotsetnosy: + reviewbot
messages: + msg54992
2020-01-22 18:38:44cedsetstatus: in-progress -> testing
reviews: 256451002
messages: + msg54991
keyword: + review
2020-01-22 18:37:00cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)