Tryton - Issues

 

Issue8990

Title Allow to select the customer bank account used for sepa payments
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components account_payment_sepa
Assigned To pokoli Keywords review
Reviews 260831007
View: 260831007

Created on 2020-01-14.14:52:31 by pokoli, last changed by roundup-bot.

Messages
New changeset ff5bc3dc68b8 by Sergi Almacellas Abellana in branch 'default':
Allow the sepa mandate to be set on draft payments
https://hg.tryton.org/tryton-env/rev/ff5bc3dc68b8
New changeset ccc89c5dbe32 by Sergi Almacellas Abellana in branch 'default':
Use process method instead of stripe journal
https://hg.tryton.org/modules/account_payment_stripe/rev/ccc89c5dbe32
New changeset f8b0419dc351 by Sergi Almacellas Abellana in branch 'default':
Allow the sepa mandate to be set on draft payments
https://hg.tryton.org/modules/account_payment_sepa/rev/f8b0419dc351
New changeset 07504d252670 by Sergi Almacellas Abellana in branch 'default':
Add process method on payment
https://hg.tryton.org/modules/account_payment/rev/07504d252670
review260831007 updated at https://codereview.tryton.org/260831007/#ps250631002
review260831007 updated at https://codereview.tryton.org/260831007/#ps276791002
review260831007 updated at https://codereview.tryton.org/260831007/#ps250581002
review260831007 updated at https://codereview.tryton.org/260831007/#ps286561003
msg54864 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-14.15:31:29
> I do not think it is the proper workflow. It is not to the accounting user to choose the mandate. Indeed I think it must be based on criteria like the origin, the currency etc. 

So you propose that the system chooses the proper mandate depending on a rule system?
In this case I think it also be usefull to let the user see what the system has choosen and override it if needed (like we do for payment terms on invoice for example).  

> For now, we have a simple protocol with the method get_sepa_mandates but it may be improved (even if it will be complicated to have a good general solution).

So that's what we try to do here. Improve the current solution by allowing the user to set the mandate (which is already supported by the get_sepa_mandates function) without adding to much complexity.
msg54863 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-14.15:13:46
I do not think it is the proper workflow. It is not to the accounting user to choose the mandate. Indeed I think it must be based on criteria like the origin, the currency etc. For now, we have a simple protocol with the method get_sepa_mandates but it may be improved (even if it will be complicated to have a good general solution).
review260831007 updated at https://codereview.tryton.org/260831007/#ps274711002
msg54860 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-14.14:52:30
In case the customer has more than one valid mandate the first one is always used but sometimes the customer may request to use another one. 

Currently the sepa_mandate is already stored on the payment but is not possible to set them. I propose to show the field on the view so the user can choose an specific mandate before processing the payments. If the value is not set the current behaviour will be keep.

In order to easly choose the mandate to be used I think the account number should be included on the mandate rec_name so its easier to select the correct mandate.
History
Date User Action Args
2020-02-17 11:21:21roundup-botsetmessages: + msg55430
2020-02-17 11:21:11roundup-botsetmessages: + msg55429
2020-02-17 11:21:02roundup-botsetmessages: + msg55428
2020-02-17 11:20:55roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg55427
2020-02-04 15:51:27reviewbotsetmessages: + msg55208
2020-01-29 22:45:28reviewbotsetmessages: + msg55115
2020-01-23 21:22:34reviewbotsetmessages: + msg55016
2020-01-16 21:35:41reviewbotsetmessages: + msg54894
2020-01-14 15:31:29pokolisetmessages: + msg54864
2020-01-14 15:13:46cedsetnosy: + ced
messages: + msg54863

Showing 10 items. Show all history (warning: this could be VERY long)