Tryton - Issues

 

Issue8987

Title Add default values for asset frequency
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components account_asset
Assigned To pokoli Keywords review
Reviews 260821002
View: 260821002

Created on 2020-01-14.09:42:27 by pokoli, last changed by roundup-bot.

Messages
New changeset 07d7e244ac41 by Sergi Almacellas Abellana in branch 'default':
Add configuration values for frequency
https://hg.tryton.org/tryton-env/rev/07d7e244ac41
New changeset c8ca9b7062b9 by Sergi Almacellas Abellana in branch 'default':
Add configuration values for frequency
https://hg.tryton.org/modules/account_asset/rev/c8ca9b7062b9
review260821002 updated at https://codereview.tryton.org/260821002/#ps272791003
review260821002 updated at https://codereview.tryton.org/260821002/#ps289141002
review260821002 updated at https://codereview.tryton.org/260821002/#ps256401002
msg54858 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-14.13:51:57
Ok, so I updated the review by allowing only to configure the default frequency and let the accountant chose the right value for the depreciation method.
msg54854 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-14.10:47:57
I agree for the frequency as it is about the accounting picture but not for the method. The method is more linked to the nature of the asset if it is something that loose value quickly or not. So for me, it should be defined on the product form of the asset or the accounting category. But I'm not sure it deserve to such customization because the accountant will anyway have to think about those aspect when creating the depreciation of the asset.
review260821002 updated at https://codereview.tryton.org/260821002/#ps280701002
msg54852 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-14.09:42:26
Normally all the assets of the company should use the same frequency and depreciation method. So for me it makes sense to allow to configure the default values of this fields on asset configuration.
History
Date User Action Args
2020-01-29 22:25:32roundup-botsetmessages: + msg55114
2020-01-29 22:25:27roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg55113
2020-01-23 20:22:50reviewbotsetmessages: + msg55012
2020-01-16 21:35:29reviewbotsetmessages: + msg54893
2020-01-14 14:07:06pokolisettitle: Add default values for asset frequency and depreciation method -> Add default values for asset frequency
2020-01-14 14:00:59reviewbotsetmessages: + msg54859
2020-01-14 13:51:58pokolisetmessages: + msg54858
2020-01-14 10:47:58cedsetnosy: + ced
messages: + msg54854
2020-01-14 10:03:37reviewbotsetnosy: + reviewbot
messages: + msg54853
2020-01-14 09:44:13pokolisetstatus: in-progress -> testing
reviews: 260821002
keyword: + review

Showing 10 items. Show all history (warning: this could be VERY long)