Tryton - Issues

 

Issue8986

Title Use depends on TaxableMixin
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components account, account_invoice, purchase, sale
Assigned To ced Keywords review
Reviews 282751002
View: 282751002

Created on 2020-01-13.15:47:56 by ced, last changed by roundup-bot.

Messages
New changeset b484461506db by Cédric Krier in branch 'default':
Use depends on TaxableMixin
https://hg.tryton.org/tryton-env/rev/b484461506db
New changeset 52033559fc3d by Cédric Krier in branch 'default':
Use depends on TaxableMixin
https://hg.tryton.org/modules/sale/rev/52033559fc3d
New changeset 29546a8eb238 by Cédric Krier in branch 'default':
Use depends on TaxableMixin
https://hg.tryton.org/modules/purchase/rev/29546a8eb238
New changeset cc793d01a064 by Cédric Krier in branch 'default':
Use depends on TaxableMixin
https://hg.tryton.org/modules/account_invoice/rev/cc793d01a064
New changeset d7a99724f330 by Cédric Krier in branch 'default':
Use depends on TaxableMixin
https://hg.tryton.org/modules/account/rev/d7a99724f330
review282751002 updated at https://codereview.tryton.org/282751002/#ps252911002
review282751002 updated at https://codereview.tryton.org/282751002/#ps262791002
msg54832 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-01-13.15:47:55
The mixin was implemented at a time when depends did not exists nor could support any methods.
But as the method _get_taxes is called from on_change, I think it will be cleaner to use depends.
History
Date User Action Args
2020-02-12 00:20:12roundup-botsetmessages: + msg55337
2020-02-12 00:20:06roundup-botsetmessages: + msg55336
2020-02-12 00:20:01roundup-botsetmessages: + msg55335
2020-02-12 00:19:52roundup-botsetmessages: + msg55334
2020-02-12 00:19:40roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg55333
2020-01-13 20:25:34reviewbotsetmessages: + msg54834
2020-01-13 16:03:07reviewbotsetnosy: + reviewbot
messages: + msg54833
2020-01-13 15:48:40cedsetstatus: in-progress -> testing
reviews: 282751002
keyword: + review
2020-01-13 15:47:56cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)