Tryton - Issues

 

Issue8932

Title Sale_stock_quantity module skips sale number sequence
Priority feature Status resolved
Superseder Nosy List ced, mrichez, roundup-bot, tbruyere
Type behavior Components sale_stock_quantity
Assigned To ced Keywords
Reviews 276591002
View: 276591002

Created on 2019-12-17.09:27:23 by mrichez, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
Capture d’écran du 2019-12-17 09-17-20.png mrichez, 2019-12-17.09:27:22 image/png
Capture d’écran du 2019-12-17 09-17-40.png mrichez, 2019-12-17.09:27:38 image/png
Messages
New changeset af85eec630c6 by Cédric Krier in branch 'default':
Check stock quantity before super calls
https://hg.tryton.org/tryton-env/rev/af85eec630c6
New changeset f9e26851e3c2 by Cédric Krier in branch 'default':
Check stock quantity before super calls
https://hg.tryton.org/modules/sale_stock_quantity/rev/f9e26851e3c2
msg54549 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-12-17.09:56:11
Here is review276591002 which should improve the behavior.
New review276591002 at https://codereview.tryton.org/276591002/#ps250431002
msg54547 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-12-17.09:48:12
For me, it is not really a bug because there are no guarantee of consecutive numbering of sale (not a strict sequence) for performance.
But I think it is good to check before calling such side effect methods.
msg54545 (view) Author: [hidden] (mrichez) Date: 2019-12-17.09:27:22
When using sale_stock_quantity module on a draft sale with a product having no stock, a warning message is raised with a sale number.
If you answer "no" to the warning message, the sale number is lost.
If you answer "yes" to the warning message, next sale number is used instead of the number on the warning.
See attachments...
History
Date User Action Args
2020-01-21 00:33:34roundup-botsetmessages: + msg54959
2020-01-21 00:33:26roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg54958
2019-12-17 09:56:12cedsetstatus: chatting -> testing
assignedto: ced
messages: + msg54549
keyword: - review
nosy: - reviewbot
2019-12-17 09:55:59reviewbotsetnosy: + reviewbot
messages: + msg54548
2019-12-17 09:55:58reviewbotsetreviews: 276591002
keyword: + review
2019-12-17 09:48:12cedsetpriority: bug -> feature
status: unread -> chatting
messages: + msg54547
nosy: + ced
2019-12-17 09:27:38mrichezsetfiles: + Capture d’écran du 2019-12-17 09-17-40.png
2019-12-17 09:27:23mrichezcreate

Showing 10 items. Show all history (warning: this could be VERY long)