Tryton - Issues

 

Issue8908

Title Improve rec_name of bank account
Priority feature Status resolved
Superseder Nosy List ced, mrichez, pokoli, reviewbot, roundup-bot, tbruyere
Type feature request Components bank
Assigned To mrichez Keywords review
Reviews 288681002
View: 288681002

Created on 2019-12-09.16:46:38 by mrichez, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
Capture d’écran du 2019-12-10 08-30-40.png mrichez, 2019-12-10.08:36:09 image/png
Messages
New changeset 962a3481e552 by Cédric Krier in branch 'default':
Add bank name and currency code to bank account rec_name
https://hg.tryton.org/tryton-env/rev/962a3481e552
New changeset 1311ecee55f1 by Maxime Richez in branch 'default':
Add bank name and currency code to bank account rec_name
https://hg.tryton.org/modules/bank/rev/1311ecee55f1
review288681002 updated at https://codereview.tryton.org/288681002/#ps286521002
review288681002 updated at https://codereview.tryton.org/288681002/#ps250521002
review288681002 updated at https://codereview.tryton.org/288681002/#ps265031002
review288681002 updated at https://codereview.tryton.org/288681002/#ps262671002
review288681002 updated at https://codereview.tryton.org/288681002/#ps250391002
review288681002 updated at https://codereview.tryton.org/288681002/#ps268611002
review288681002 updated at https://codereview.tryton.org/288681002/#ps252761002
msg54406 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-12-10.10:02:05
On 2019-12-10 08:36, Maxime Richez wrote:
> maybe currency could also be included in the rec_name ?

Then I would use the form: <number> (<bank name> <currency code>)
msg54405 (view) Author: [hidden] (mrichez) Date: 2019-12-10.08:36:09
Here's a screen capture when you have to choose bank account for SEPA payment... 
Unless you really know your bank accounts (or you have few accounts), i think it make sense to have a better rec_name for accounts to allow user to find the right account easily... (maybe currency could also be included in the rec_name ?)
msg54404 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-12-10.01:20:12
I think it makes sense because people does not remember the numbers but they can remember the bank name (not the number of the bank in the account number). So the use case will be that you have to make payment but all you know for sure is that it is on the account on a specific bank.
msg54389 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-12-09.22:59:27
I'm not sure if this is the right aproach.

Normally the number should be unique enought to identify the bank account. In spain the bank number is part of the account number so it is possible to identify the bank directly from the number. Is this not the case for your country?
New review288681002 at https://codereview.tryton.org/288681002/#ps288691002
msg54382 (view) Author: [hidden] (mrichez) Date: 2019-12-09.16:46:37
Currently, it uses the first account_number. So when selecting an account_number in a one2many field you don't know to which bank it is linked.
History
Date User Action Args
2020-01-11 23:56:36roundup-botsetmessages: + msg54817
2020-01-11 23:56:33roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg54816
2020-01-10 11:33:16reviewbotsetmessages: + msg54798
2020-01-10 09:00:28reviewbotsetmessages: + msg54794
2020-01-06 11:24:14reviewbotsetmessages: + msg54741
2019-12-16 09:57:42reviewbotsetmessages: + msg54518
2019-12-13 09:01:43reviewbotsetmessages: + msg54484
2019-12-10 10:59:11reviewbotsetmessages: + msg54408
2019-12-10 10:28:59reviewbotsetmessages: + msg54407
2019-12-10 10:02:06cedsetmessages: + msg54406

Showing 10 items. Show all history (warning: this could be VERY long)