Tryton - Issues

 

Issue8852

Title Adapt import_zip script to use the right subdivision type per country
Priority feature Status resolved
Superseder Nosy List albertca, ced, pokoli, resteve, reviewbot, roundup-bot
Type feature request Components
Assigned To pokoli Keywords review
Reviews 266761002
View: 266761002

Created on 2019-11-21.17:44:00 by albertca, last changed by roundup-bot.

Messages
New changeset 12aa28dba7d2 by Sergi Almacellas Abellana in branch 'default':
Create a zip entry for each subdivision found
https://hg.tryton.org/tryton-env/rev/12aa28dba7d2
New changeset 0bd5a6ee2ea3 by Sergi Almacellas Abellana in branch 'default':
Create a zip entry for each subdivision found
https://hg.tryton.org/modules/country/rev/0bd5a6ee2ea3
review266761002 updated at https://codereview.tryton.org/266761002/#ps262931007
review266761002 updated at https://codereview.tryton.org/266761002/#ps253001003
msg55104 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-29.16:49:32
Here is review266761002 which implements msg53411
msg53411 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-11-22.00:21:25
I would see no problem to create a zip entry for each code found.
msg53410 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-21.22:43:48
Instead of the parameter I think it will be better to read the allowed types for the country and interate between codes until one is found.
msg53409 (view) Author: [hidden] (resteve) Date: 2019-11-21.21:28:46
Load province (Barcelona, Zaragoza,...) instead of Comunity region (Catalunya, Aragón...) could be new parameter in scripts/import_zip.py and the user decide which column like to load in the database (code1 or code2)
msg53407 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-21.19:17:57
Using invalid values causes any issue on the User Interface? Or the value is directly ignored?
msg53398 (view) Author: [hidden] (albertca) (Tryton committer) Date: 2019-11-21.17:43:59
Now that we limit the type of subdivisions per country in addresses [1], we should adapt the country import_zip.py script to honour the same criteria.

For example, in Spain it would need to use "code2" instead of "code1" in this line:

https://hg.tryton.org/modules/country/file/tip/scripts/import_zip.py#l84

Maybe we should just always use the smaller (more precise) subdivision.

[1] https://hg.tryton.org/modules/party/rev/15ef94c7a85e
History
Date User Action Args
2020-02-17 09:59:55roundup-botsetmessages: + msg55422
2020-02-17 09:59:47roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg55421
2020-02-04 15:51:39reviewbotsetmessages: + msg55210
2020-01-29 16:52:13reviewbotsetnosy: + reviewbot
messages: + msg55106
2020-01-29 16:51:19pokolisetstatus: chatting -> testing
2020-01-29 16:49:33pokolisetreviews: 266761002
assignedto: pokoli
messages: + msg55104
keyword: + review
2019-11-22 00:21:26cedsetnosy: + ced
messages: + msg53411
2019-11-21 22:43:49pokolisetmessages: + msg53410
2019-11-21 21:28:46restevesetnosy: + resteve
messages: + msg53409
2019-11-21 19:17:57pokolisetstatus: unread -> chatting
nosy: + pokoli
messages: + msg53407

Showing 10 items. Show all history (warning: this could be VERY long)