Tryton - Issues

 

Issue8847

Title "Always ignore this warning" value is ignored
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type behavior Components sao, tryton
Assigned To ced Keywords review
Reviews 272541002
View: 272541002

Created on 2019-11-21.09:57:00 by pokoli, last changed by roundup-bot.

Messages
New changeset dc505d15a367 by Cédric Krier in branch '5.4':
Properly test always checkbox in user warning
https://hg.tryton.org/sao/rev/dc505d15a367

New changeset 2988359c6ae4 by Cédric Krier in branch '5.2':
Properly test always checkbox in user warning
https://hg.tryton.org/sao/rev/2988359c6ae4

New changeset b94b4dbddcf3 by Cédric Krier in branch '5.0':
Properly test always checkbox in user warning
https://hg.tryton.org/sao/rev/b94b4dbddcf3
New changeset 07444a5804b6 by Cédric Krier in branch 'default':
Properly test always checkbox in user warning
https://hg.tryton.org/tryton-env/rev/07444a5804b6
New changeset 0b026afcba63 by Cédric Krier in branch 'default':
Properly test always checkbox in user warning
https://hg.tryton.org/tryton/rev/0b026afcba63
New changeset 6706f4c73bcc by Cédric Krier in branch 'default':
Properly test always checkbox in user warning
https://hg.tryton.org/sao/rev/6706f4c73bcc
msg53756 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-30.17:37:14
Thanks, tryton behaves as expected with the latest patchset.
review272541002 updated at https://codereview.tryton.org/272541002/#ps276501002
msg53725 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-11-29.00:41:39
I can not reproduce on tryton but I think it may be an implementation detail about when the callback are run.
So I uploaded a version of the patch for tryton also with the same design.
msg53709 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-27.18:18:26
Sao patch fixes the issue on sao but I can still reproduce the issue on tryton. 

For testing just set click the "Yes" button on the warning without clicking the "always" check. The warning is saved as always on database. You can see it by executing the following query:

payment=# select * from res_user_warning;
 id | always |        create_date        | create_uid |           name           | user | write_date | write_uid 
----+--------+---------------------------+------------+--------------------------+------+------------+-----------
 54 | t      | 2019-11-27 17:16:06.51754 |          1 | receivable:party.party,2 |    1 |            |
review272541002 updated at https://codereview.tryton.org/272541002/#ps280501002
msg53451 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-11-24.00:35:59
I can not reproduce on tryton, the value for always varying according if I check or not the box.
Here is review272541002 for sao.
msg53373 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-21.09:56:59
On latest trunk the "always ignore this warning" have diferent behaviour depending on the client: 

* On sao: Always sents the False value no mather if it's clicked or not.
* On tryon: Always sent tthe True value no mather if it's clicked or not.

Both clients should send the value correctly to the server.
History
Date User Action Args
2019-12-10 00:32:55roundup-botsetmessages: + msg54400
keyword: - backport
2019-12-05 21:44:20roundup-botsetmessages: + msg54300
2019-12-05 21:44:19roundup-botsetmessages: + msg54299
2019-12-05 21:44:16roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg54298
2019-12-05 21:42:43cedsetcomponent: + tryton
keyword: + backport
2019-11-30 17:37:14pokolisetmessages: + msg53756
2019-11-29 00:46:33reviewbotsetmessages: + msg53726
2019-11-29 00:41:40cedsetmessages: + msg53725
2019-11-27 18:18:26pokolisetmessages: + msg53709
2019-11-24 01:13:16reviewbotsetnosy: + reviewbot
messages: + msg53452

Showing 10 items. Show all history (warning: this could be VERY long)