Tryton - Issues

 

Issue8824

Title Using widget="binary" for fields.Text result in a TypeError
Priority bug Status resolved
Superseder Nosy List nicoe, reviewbot, roundup-bot
Type crash Components tryton
Assigned To nicoe Keywords review
Reviews 258401002
View: 258401002

Created on 2019-11-14.19:26:25 by nicoe, last changed by roundup-bot.

Messages
New changeset 77c4bf83616f by Nicolas Évrard in branch '5.4':
Guess encoding when sending bytes to a Char widget
https://hg.tryton.org/tryton/rev/77c4bf83616f

New changeset 9fa57d58ee48 by Nicolas Évrard in branch '5.2':
Guess encoding when sending bytes to a Char widget
https://hg.tryton.org/tryton/rev/9fa57d58ee48

New changeset 792f649e6433 by Nicolas Évrard in branch '5.0':
Guess encoding when sending bytes to a Char widget
https://hg.tryton.org/tryton/rev/792f649e6433
New changeset 41074f65084f by Nicolas ?vrard in branch 'default':
Guess encoding when sending bytes to a Char widget
https://hg.tryton.org/tryton-env/rev/41074f65084f
New changeset 08f29b53ce86 by Nicolas ?vrard in branch 'default':
Guess encoding when sending bytes to a Char widget
https://hg.tryton.org/tryton/rev/08f29b53ce86
review258401002 updated at https://codereview.tryton.org/258401002/#ps254671002
review258401002 updated at https://codereview.tryton.org/258401002/#ps270571003
review258401002 updated at https://codereview.tryton.org/258401002/#ps274261002
msg53192 (view) Author: [hidden] (nicoe) (Tryton committer) Date: 2019-11-14.19:26:24
Previously in account_payment_sepa we had a fields.Text that was rendered with a Text widget and a Binary widget.

In this case, a decode error occurs when the user set a file as the Binary widget will send bytes to the record and the Text widget expect a str.

We might want to use the same strategy we used for the HTML widget and guess the encoding when the Char widget receives bytes.
History
Date User Action Args
2019-11-24 20:52:27roundup-botsetmessages: + msg53468
keyword: - backport
2019-11-21 15:40:27roundup-botsetmessages: + msg53392
2019-11-21 15:40:21roundup-botsetstatus: chatting -> resolved
nosy: + roundup-bot
messages: + msg53389
2019-11-18 16:34:05reviewbotsetmessages: + msg53323
2019-11-18 16:15:31reviewbotsetmessages: + msg53322
2019-11-15 17:01:20reviewbotsetstatus: unread -> chatting
nosy: + reviewbot
messages: + msg53222
2019-11-15 12:07:11cedsetkeyword: + backport
2019-11-14 19:26:25nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)