Allow to export book of issued and received Invoices

assigned to @pokoli

added accounting type::feature + 1 deleted label

added 1 deleted label and removed 1 deleted label

review250051002 updated at https://codereview.tryton.org/250051002/#ps264331003

I do not see where it defines the CSV format (nor that the CSV format must be used). Also neither that it should be a file for this.

> I do not see where it defines the CSV format (nor that the CSV format must be used). Also neither that it should be a file for this.

Indeed there is any requirement about the format but they require you to send this information in a readable format so the CSV export is accepted.

If there is no format how do you know which data to put?

> If there is no format how do you know which data to put?

Because on the links I posted it details the fields that should be included:ç

"The register book of issued invoices shall include the following information:the number and, if applicable, the series, the date of issue, the date of performance if different from the latter, the first name and surnames, the recipients trade name or complete denomination and Tax Identification Number (NIF), the taxable base of the operations, the tax rate and the tax amount."

And our CSV format when there are multiple different taxes is supported? I would find this strange because it is very custom.

El 2/10/19 a les 17:05, Cédric Krier ha escrit:
> And our CSV format when there are multiple different taxes is supported? I would find this strange because it is very custom.

Yes, I've used this format for sending the 2018 books without any issues.

BTW I think the format we are using for exporting multiple formats is quite easy to understand.

On 2019-10-02 17:45, Sergi Almacellas Abellana wrote:
> El 2/10/19 a les 17:05, Cédric Krier ha escrit:
> > And our CSV format when there are multiple different taxes is supported? I would find this strange because it is very custom.
>
> Yes, I've used this format for sending the 2018 books without any issues.

Did you have different taxes?

> BTW I think the format we are using for exporting multiple formats is quite easy to understand.

We inherited from Odoo and it was the first time I ever seen it.

El 2/10/19 a les 17:59, Cédric Krier ha escrit:
> On 2019-10-02 17:45, Sergi Almacellas Abellana wrote:
>> El 2/10/19 a les 17:05, Cédric Krier ha escrit:
>>> And our CSV format when there are multiple different taxes is supported? I would find this strange because it is very custom.
>> Yes, I've used this format for sending the 2018 books without any issues.
> Did you have different taxes?
>

Yes we have several invoices which had two taxes (IVA and IRPF)

Is not there any constraint on the domain to use? Should not it be all the invoice for a period or a fiscal year?

> Is not there any constraint on the domain to use?
Yes, only invoices with number should be used.
> Should not it be all the invoice for a period or a fiscal year?
This are not constraints but normally you generate the report for a fiscalyear, for a period

Sorry but I do not understand what is this export. It is not clear at all how it works. When is it generated? Which data should be included? For which purpose?

When I look at this module [1], it seems that it is more than a simple CSV export:

* only the VAT part should be shown not other taxes
* A summary of taxes
* the invoice and refund seems to be separated

Another point not from the module is that I find it strange to not use the reference for supplier invoice instead of the internal number.

So for me, it looks like account.be.vat_customer but with full details.I would see a dedicated query model with contextual filter fiscal year and/or period. With finally a CSV export.

[1] https://github.com/OCA/l10n-spain/tree/11.0/l10n_es_vat_book

Indeed the norma has been updated and there are some changes starting on January 1st 2020. Here is the normative (only in spanish sorry):

https://www.agenciatributaria.es/static_files/AEAT/Contenidos_Comunes/La_Agencia_Tributaria/Informacion_institucional/Campanias/IVA/Informacion_tecnica/Formato_Electronico_Libros_Registro_IVA.pdf

Indeed with the new legislation on the supplier invoices the supplier number (reference) should be used.

I'm wondering if we should allow to make this field required for all supplier invoices probably using the same desing as we did on #8445 (closed), so we can activate this feature on the spanish companies.

added 1 deleted label and removed 1 deleted label

I had one extra doubt with I resolved with our accountant. This was when the invoice has VAT but is in a different curreny. The accountant told me that in case of diferent currencies in the VAT book we should use the amount in the copmany currency (EURO).

New review310091002 at https://codereview.tryton.org/310091002/#ps295941002

I've uploaded review310091002 which implements the table query to compute the vat book. It requires #9182 (closed) to properly report surcharge tax amounts.

It is still missing a test scenario and the reports to export the data with the tax authority format (CSV file). But all of the amounts are propertly shown.

I based the report on account_invoice_tax but as the requirment is to always use the company currency for the amount I'm wondering if it won't be better to use the account_tax_line of the invoice because they are already on the company currency.

Toughts?