Tryton - Issues

 

Issue8570

Title Search also on replaced party
Priority feature Status chatting
Superseder Nosy List ced, nicoe, reviewbot
Type feature request Components party
Assigned To nicoe Keywords review
Reviews 267801003
View: 267801003

Created on 2019-08-13.14:25:58 by ced, last changed by reviewbot.

Messages
review267801003 updated at https://codereview.tryton.org/267801003/#ps272811002
review267801003 updated at https://codereview.tryton.org/267801003/#ps262591003
review267801003 updated at https://codereview.tryton.org/267801003/#ps276441003
review267801003 updated at https://codereview.tryton.org/267801003/#ps276391006
review267801003 updated at https://codereview.tryton.org/267801003/#ps270591002
review267801003 updated at https://codereview.tryton.org/267801003/#ps249901002
msg51595 (view) Author: [hidden] (nicoe) (Tryton committer) Date: 2019-08-31.00:49:27
I updated the review with the design of msg51375
msg51375 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-21.00:22:50
I find the solution of searching on replaced parties complex and not very efficient (with recursive). I'm wondering if it will not be better to copy identifiers from the replaced party to the destination. Of course only non-existing identifier. But also add a new one for the replaced code.
msg51374 (view) Author: [hidden] (nicoe) (Tryton committer) Date: 2019-08-20.18:49:20
Here's the review
msg51276 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-13.14:25:58
When a party has been replaced by another, it will be good that searching using the code of the former party will returns the active party.
History
Date User Action Args
2020-01-30 15:25:27reviewbotsetmessages: + msg55148
2019-11-27 10:37:26reviewbotsetmessages: + msg53696
2019-11-25 13:10:54reviewbotsetmessages: + msg53485
2019-11-22 18:45:52reviewbotsetmessages: + msg53433
2019-11-19 18:43:04reviewbotsetmessages: + msg53341
2019-08-31 01:05:24reviewbotsetnosy: + reviewbot
messages: + msg51598
2019-08-31 00:49:27nicoesetmessages: + msg51595
2019-08-21 00:22:51cedsetmessages: + msg51375
2019-08-20 18:49:37nicoesetkeyword: - easy
2019-08-20 18:49:20nicoesetreviews: 267801003
status: unread -> chatting
messages: + msg51374
keyword: + review

Showing 10 items. Show all history (warning: this could be VERY long)