Tryton - Issues

 

Issue8562

Title Restore colors on tree view
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components sao, tryton, trytond
Assigned To ced Keywords review
Reviews 261951002
View: 261951002

Created on 2019-08-08.17:36:56 by ced, last changed by ced.

Files
File name Uploaded Type Edit Remove
2019-08-08-173756_970x776_scrot.png ced, 2019-08-08.17:44:21 image/png
2019-08-08-173808_970x776_scrot.png ced, 2019-08-08.17:44:30 image/png
Screenshot_2019-08-08 Customer Invoices - Tryton.png ced, 2019-08-08.17:44:13 image/png
Screenshot_2019-08-08 Parties - Tryton.png ced, 2019-08-08.17:44:00 image/png
Messages
msg51147 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-09.14:07:00
> I'm wondering if we should allow to add new visuals by customizing the client theme. What do you think?

I do not think. The issue4861 was about too much customization.
My proposal is about rationalize and reduce to the minimal needed.
If someone want more meaning then he can use icons.
msg51146 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-08-09.13:48:09
> Also I think I will add a new value "muted" which change the foreground (for #fff by default). For example, it could be used to lighten canceled documents.

I'm wondering if we should allow to add new visuals by customizing the client theme. What do you think?
review261951002 updated at https://codereview.tryton.org/261951002/#ps249741012
msg51143 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-09.10:15:48
I'm wondering if the attribute should not be called "visual" instead of "color".
Also I think I will add a new value "muted" which change the foreground (for #fff by default). For example, it could be used to lighten canceled documents.
msg51133 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-08.18:52:45
Because info is the same color as the selected. And because I do not see it as meaningful, all data are info.
msg51132 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-08-08.18:49:16
Why not adding info also?
review261951002 updated at https://codereview.tryton.org/261951002/#ps257881002
msg51130 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-08.17:44:00
Here is review261951002. I added some colors on party payable/receivabe today, on invoice with amount to pay, on purchase and sale with exception.

Here are some screenshots.
msg51129 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-08.17:36:55
issue4861 removed colors because they were hard coded, did not work with theme etc.
But as states in msg22147, a better implementation would be welcomed.
So here is my proposal, we could limit color on tree to three values: success, warning and danger (taken from bootstrap [1]). This way they can be integrated into the theme. Unfortunately, GTK does not allow yet CSS for row [2] but we can manage them like we do for the icons: having a list of configured colors.

[1] https://getbootstrap.com/docs/3.4/css/#tables-contextual-classes
[2] https://gitlab.gnome.org/GNOME/gtk/issues/581
History
Date User Action Args
2019-08-09 14:07:01cedsetmessages: + msg51147
2019-08-09 13:48:09pokolisetmessages: + msg51146
2019-08-09 12:18:19reviewbotsetmessages: + msg51145
2019-08-09 10:15:48cedsetmessages: + msg51143
2019-08-08 18:52:45cedsetmessages: + msg51133
2019-08-08 18:49:16pokolisetnosy: + pokoli
messages: + msg51132
2019-08-08 17:45:47reviewbotsetnosy: + reviewbot
messages: + msg51131
2019-08-08 17:44:30cedsetfiles: + 2019-08-08-173808_970x776_scrot.png
2019-08-08 17:44:21cedsetfiles: + 2019-08-08-173756_970x776_scrot.png
2019-08-08 17:44:13cedsetfiles: + Screenshot_2019-08-08 Customer Invoices - Tryton.png

Showing 10 items. Show all history (warning: this could be VERY long)