Support dot notation on eval
Following https://codereview.tryton.org/287821002/#msg8
It will allow to spot issues like #8523 (closed) while developing.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sergi Almacellas Abellana assigned to @pokoli
assigned to @pokoli
- Sergi Almacellas Abellana added trytond type::feature + 1 deleted label
added trytond type::feature + 1 deleted label
- Author Developer
Here is review255711002, I'm currently running the test on all modules to see if there is any module that should be fixed.
New review255711002 at https://codereview.tryton.org/255711002/#ps249691002
review255711002 updated at https://codereview.tryton.org/255711002/#ps255711003
review255711002 updated at https://codereview.tryton.org/255711002/#ps267691002
review255711002 updated at https://codereview.tryton.org/255711002/#ps285621002
- Owner
Could not we support the dotted notation in Eval instead? As it is a common mistakes, we could simply avoid it by implementing what user expect.
So Eval could split on '.' and loop over each item to get the value.
But module fixes from review255711002 should be kept and apply for backport. review255711002 updated at https://codereview.tryton.org/255711002/#ps253911003
- Author Developer
I updated review255711002 to be based on 5.2 and include only modules, so it can be applied for backport. Just note that the fix for notification_email should be also applied on trunk.
Here is review287841003 that add support for dot notation in Eval - Sergi Almacellas Abellana added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Owner
I think it is better to have review255711002 applied on trunk and backported before applying review287841003.
review287841003 updated at https://codereview.tryton.org/287841003/#ps283821004
review287841003 updated at https://codereview.tryton.org/287841003/#ps257851004
review287841003 updated at https://codereview.tryton.org/287841003/#ps270031002
review287841003 updated at https://codereview.tryton.org/287841003/#ps261941002
review287841003 updated at https://codereview.tryton.org/287841003/#ps272041002
review287841003 updated at https://codereview.tryton.org/287841003/#ps287911002
review287841003 updated at https://codereview.tryton.org/287841003/#ps265851002
- Owner
Could you commit review255711002 so we can backport fixes.