Support dot notation on eval
Following https://codereview.tryton.org/287821002/#msg8
It will allow to spot issues like #8523 (closed) while developing.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sergi Almacellas Abellana assigned to @pokoli
assigned to @pokoli
- Sergi Almacellas Abellana added trytond type::feature + 1 deleted label
added trytond type::feature + 1 deleted label
- Author Developer
Here is review255711002, I'm currently running the test on all modules to see if there is any module that should be fixed.
New review255711002 at https://codereview.tryton.org/255711002/#ps249691002
review255711002 updated at https://codereview.tryton.org/255711002/#ps255711003
review255711002 updated at https://codereview.tryton.org/255711002/#ps267691002
review255711002 updated at https://codereview.tryton.org/255711002/#ps285621002
- Owner
Could not we support the dotted notation in Eval instead? As it is a common mistakes, we could simply avoid it by implementing what user expect.
So Eval could split on '.' and loop over each item to get the value.
But module fixes from review255711002 should be kept and apply for backport. review255711002 updated at https://codereview.tryton.org/255711002/#ps253911003
- Author Developer
I updated review255711002 to be based on 5.2 and include only modules, so it can be applied for backport. Just note that the fix for notification_email should be also applied on trunk.
Here is review287841003 that add support for dot notation in Eval - Sergi Almacellas Abellana added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Owner
I think it is better to have review255711002 applied on trunk and backported before applying review287841003.
review287841003 updated at https://codereview.tryton.org/287841003/#ps283821004
review287841003 updated at https://codereview.tryton.org/287841003/#ps257851004
review287841003 updated at https://codereview.tryton.org/287841003/#ps270031002
review287841003 updated at https://codereview.tryton.org/287841003/#ps261941002
review287841003 updated at https://codereview.tryton.org/287841003/#ps272041002
review287841003 updated at https://codereview.tryton.org/287841003/#ps287911002
review287841003 updated at https://codereview.tryton.org/287841003/#ps265851002
- Owner
Could you commit review255711002 so we can backport fixes.
New changeset 79e10cde69e0 by Sergi Almacellas Abellana in branch 'default':
Remove dot notation usage on Eval
https://hg.tryton.org/modules/carrier_weight/rev/79e10cde69e0- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
New changeset c02a608abac6 by Sergi Almacellas Abellana in branch 'default':
Remove dot notation usage on Eval
https://hg.tryton.org/tryton-env/rev/c02a608abac6- Owner
It is missing account_invoice and notification_email fixes.
- Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Cédric Krier reopened
reopened
- Author Developer
> It is missing account_invoice and notification_email fixes.
Those patches where included on #8523 (closed) and #8546 (closed) which are already resolved (and backported)
So only carrier_weight was missing. review287841003 updated at https://codereview.tryton.org/287841003/#ps265881002
New changeset a37f097e6c2f by Sergi Almacellas Abellana in branch '5.2':
Remove dot notation usage on Eval
https://hg.tryton.org/modules/carrier_weight/rev/a37f097e6c2f
New changeset 762ec99354cb by Sergi Almacellas Abellana in branch '5.0':
Remove dot notation usage on Eval
https://hg.tryton.org/modules/carrier_weight/rev/762ec99354cb
New changeset bb99ba0baa99 by Sergi Almacellas Abellana in branch '4.8':
Remove dot notation usage on Eval
https://hg.tryton.org/modules/carrier_weight/rev/bb99ba0baa99
New changeset 9f4f66968fdc by Sergi Almacellas Abellana in branch '4.6':
Remove dot notation usage on Eval
https://hg.tryton.org/modules/carrier_weight/rev/9f4f66968fdc
New changeset 35847395e1bb by Sergi Almacellas Abellana in branch '4.4':
Remove dot notation usage on Eval
https://hg.tryton.org/modules/carrier_weight/rev/35847395e1bb- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
- Sergi Almacellas Abellana added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Sergi Almacellas Abellana reopened
reopened
- Sergi Almacellas Abellana added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
review287841003 updated at https://codereview.tryton.org/287841003/#ps258081002
review287841003 updated at https://codereview.tryton.org/287841003/#ps280131002
review287841003 updated at https://codereview.tryton.org/287841003/#ps282141002
review287841003 updated at https://codereview.tryton.org/287841003/#ps288101002
New changeset 22071504df82 by Sergi Almacellas Abellana in branch 'default':
Support dot notation on PYSON Eval
https://hg.tryton.org/proteus/rev/22071504df82- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
New changeset 19cad7f898a4 by Sergi Almacellas Abellana in branch 'default':
Support dot notation on PYSON Eval
https://hg.tryton.org/sao/rev/19cad7f898a4New changeset 36abc92c806a by Sergi Almacellas Abellana in branch 'default':
Support dot notation on PYSON Eval
https://hg.tryton.org/tryton/rev/36abc92c806aNew changeset 6fe6d9056f29 by Sergi Almacellas Abellana in branch 'default':
Support dot notation on PYSON Eval
https://hg.tryton.org/trytond/rev/6fe6d9056f29New changeset a45775f029f6 by Sergi Almacellas Abellana in branch 'default':
Support dot notation on PYSON Eval
https://hg.tryton.org/tryton-env/rev/a45775f029f6- Cédric Krier mentioned in issue #11109 (closed)
mentioned in issue #11109 (closed)