Tryton - Issues



Title Support dot notation on eval
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components trytond
Assigned To pokoli Keywords backport, review
Reviews 255711002, 287841003
View: 255711002, 287841003

Created on 2019-07-25.09:57:29 by pokoli, last changed by reviewbot.

review287841003 updated at
review287841003 updated at
review287841003 updated at
review287841003 updated at
review287841003 updated at
review287841003 updated at
msg50917 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-26.14:05:01
I think it is better to have review255711002 applied on trunk and backported before applying review287841003.
msg50916 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-07-26.13:49:55
I updated review255711002 to be based on 5.2 and include only modules, so it can be applied for backport. Just note that the fix for notification_email should be also applied on trunk. 

Here is review287841003 that add support for dot notation in Eval
review255711002 updated at
msg50881 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-25.13:10:25
Could not we support the dotted notation in Eval instead? As it is a common mistakes, we could simply avoid it by implementing what user expect.
So Eval could split on '.' and loop over each item to get the value.

But module fixes from review255711002 should be kept and apply for backport.
review255711002 updated at
review255711002 updated at
review255711002 updated at
New review255711002 at
msg50859 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-07-25.09:58:40
Here is review255711002, I'm currently running the test on all modules to see if there is any module that should be fixed.
msg50858 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-07-25.09:57:28

It will allow to spot issues like issue8523 while developing.
Date User Action Args
2019-08-09 17:11:47reviewbotsetmessages: + msg51221
2019-08-08 14:21:26reviewbotsetmessages: + msg51125
2019-08-08 09:21:03reviewbotsetmessages: + msg51117
2019-07-31 14:35:30reviewbotsetmessages: + msg50996
2019-07-30 17:38:35reviewbotsetmessages: + msg50968
2019-07-26 14:05:19reviewbotsetmessages: + msg50918
2019-07-26 14:05:01cedsetmessages: + msg50917
2019-07-26 13:49:56pokolisetstatus: in-progress -> testing
reviews: 255711002 -> 255711002, 287841003
messages: + msg50916
title: Ensure dot notation is not used on eval -> Support dot notation on eval
2019-07-26 12:56:32reviewbotsetmessages: + msg50915
2019-07-25 13:10:25cedsetnosy: + ced
messages: + msg50881

Showing 10 items. Show all history (warning: this could be VERY long)