Tryton - Issues

 

Issue8363

Title Improve _sync_inventory_to_outgoing
Priority feature Status testing
Superseder Allow move as move's origin
View: 8253
Nosy List ced, mrichez, pokoli, resteve, reviewbot, tbruyere
Type performance Components stock, stock_lot
Assigned To ced Keywords review
Reviews 261811002
View: 261811002

Created on 2019-05-20.15:31:20 by ced, last changed by reviewbot.

Messages
review261811002 updated at https://codereview.tryton.org/261811002/#ps277581002
msg50585 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-09.17:54:48
Here is review261811002 which simplify the synchronization but also support lot for internal shipment.
The major difference is that changing the product of a inventory move will affect the outgoing move either.
A second difference is that move without any inventory will be set to zero instead of being deleted.
msg49776 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-05-20.15:31:19
With issue8253, we will have a link between the inventory moves and the outgoing moves. So I think the synchronization could be simplified and hardened by using the origin.
If we synchronize by origin then we could simplify the design for stock_lot.
So the algorithm could be:

- compute quantity per origin and a key (default: product and extended with lot) from the inventory moves
- update quantity of outgoing moves using origin of quantity:
   - check if the key is valid for original move:
     - if yes: update quantity if lower or create new move if higher
     - if no: copy with default quantity and other key values
- update quantity to zero for missing origin
- create new move for unknown origins

This will also support to change the product (standard replacement) on inventory move and update it on the outgoing move.
History
Date User Action Args
2019-07-09 18:08:14reviewbotsetnosy: + reviewbot
messages: + msg50586
2019-07-09 17:54:48cedsetstatus: in-progress -> testing
reviews: 261811002
messages: + msg50585
keyword: + review
2019-07-04 15:35:36pokolisetnosy: + pokoli
2019-05-21 10:21:48tbruyeresetnosy: + tbruyere, mrichez
2019-05-20 16:22:27restevesetnosy: + resteve
2019-05-20 15:31:20cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)