Tryton - Issues

 

Issue8360

Title Set subscription end date when closing it
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components sale_subscription
Assigned To pokoli Keywords review
Reviews 269531002
View: 269531002

Created on 2019-05-17.21:10:10 by pokoli, last changed by reviewbot.

Messages
review269531002 updated at https://codereview.tryton.org/269531002/#ps258371002
msg49843 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-05-24.09:16:19
It seems I've uploaded two reviews of same patch, so I removed one of them.
msg49840 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-05-24.00:43:11
Why is there two reviews?
review269531002 updated at https://codereview.tryton.org/269531002/#ps271431002
New review271421002 at https://codereview.tryton.org/271421002/#ps263501003
msg49756 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-05-17.21:10:09
The subscrpition is closed when all the lines have have been totaly consumed. In this case the subscription has and empty end date. 

I think it makes sense to use the max end date for the lines as end date a subscription end date, as it's the date when the subscription has been finished.
History
Date User Action Args
2019-11-08 01:36:52reviewbotsetmessages: + msg53086
2019-05-24 09:16:20pokolisetreviews: 269531002, 271421002 -> 269531002
messages: + msg49843
2019-05-24 00:43:12cedsetnosy: + ced
messages: + msg49840
2019-05-17 21:35:44reviewbotsetmessages: + msg49759
2019-05-17 21:35:34reviewbotsetnosy: + reviewbot
messages: + msg49758
2019-05-17 21:35:33reviewbotsetreviews: 269531002 -> 269531002, 271421002
2019-05-17 21:12:44pokolisetstatus: unread -> testing
reviews: 269531002
keyword: + review
2019-05-17 21:10:10pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)