Tryton - Issues

 

Issue8351

Title Allow to deactivate subscriptions service
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components sale_subscription
Assigned To pokoli Keywords review
Reviews 251361002
View: 251361002

Created on 2019-05-15.14:28:32 by pokoli, last changed by roundup-bot.

Messages
New changeset 69f889c36df3 by Sergi Almacellas Abellana in branch 'default':
Allow services to be deactivated
https://hg.tryton.org/tryton-env/rev/69f889c36df3
New changeset 3745b4750a4d by Sergi Almacellas Abellana in branch 'default':
Allow services to be deactivated
https://hg.tryton.org/modules/sale_subscription/rev/3745b4750a4d
review251361002 updated at https://codereview.tryton.org/251361002/#ps255431002
msg49732 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-05-16.21:07:54
Here is review251361002 which implements it
msg49730 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-05-16.16:21:52
For me, the service should be deactivatable because the product can be used for other usage.
msg49723 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-05-15.14:28:31
It may be the case that a subscription service is no longer ofered by the company, so it should be deactivated like we do for productions. 

I'm wondering if it's worth to add the active field on the subscription service or use a functional field that mimics the product behaviour, so if the product is inactive the service will become inactive.
History
Date User Action Args
2019-05-24 09:24:12roundup-botsetmessages: + msg49845
2019-05-24 09:24:07roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg49844
2019-05-16 21:32:27reviewbotsetnosy: + reviewbot
messages: + msg49733
2019-05-16 21:07:54pokolisetstatus: chatting -> testing
reviews: 251361002
messages: + msg49732
keyword: + review
assignedto: pokoli
2019-05-16 16:21:53cedsetstatus: unread -> chatting
nosy: + ced
messages: + msg49730
2019-05-15 14:28:32pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)