Add subdivisions to match account tax rule
From https://discuss.tryton.org/t/add-subdivisiions-to-match-account-tax-rule/1290
Files
Download | Creator | Timestamp | Type |
---|---|---|---|
account_tax_rule_country_subdivision.diff | @resteve | 2019-04-03 07:49:01.451000 UTC | text/plain |
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Raimon Esteve added accounting type::feature + 1 deleted label
added accounting type::feature + 1 deleted label
- Developer
Please follow http://www.tryton.org/develop
and if you are going to work on the issue assign it to yourself - Developer
Some comments about the patch:
- You should add a CHANGELOG entry
- As subdivision is a tree I'm wondering if we should match also parent subdivisions.
Following your use case from Canary Islands, Santa Cruz de Tenerife is a province which is child of Canary Islands. So when setting the subdivision as Canary Islands, it should match also when the address is from Santa Cruz de Tenerife - Owner
I mark it as invalid for two reasons:
- the discussion is far from being settle
- @resteve does not want to follow the contribution process (see #8251 (closed)) - Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Cédric Krier closed
closed
- Owner
I have implemented review257851003 which manage the subdivision tree and include tests.
- Cédric Krier assigned to @ced
assigned to @ced
- Cédric Krier added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Cédric Krier reopened
reopened
review257851003 updated at https://codereview.tryton.org/257851003/#ps273681005
New changeset c72071b493f7 by Cédric Krier in branch 'default':
Add subdivision as criteria
https://hg.tryton.org/modules/account_tax_rule_country/rev/c72071b493f7- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
New changeset 39a7529ec9e3 by Cédric Krier in branch 'default':
Add subdivision as criteria
https://hg.tryton.org/tryton-env/rev/39a7529ec9e3