Add warning when an supplier with same reference already exists
As the reference field is used to indicate the number of the supplier invoice, it can be used to determine if the invoice is already entered in the system.
It will be great if we can show a warning message when trying to post the same supplier invoice multiple times (an invoice from the same supplier with the same reference)
Activity
assigned to @pokoli
added accounting type::feature + 1 deleted label
review265201002 updated at https://codereview.tryton.org/265201002/#ps253261002
> Cédric Krier added the comment:
>
> I do not think a warning is the right way because it prevents automatic creation of document.
I've added a context flag that allows to skip the test. This can be set on automatic processes to skip the warning and create the documents.
> But here as the data is not controlled by Tryton, we can not guess that the reference will be unique per party.
That's why I set it as warning so the system allows to include duplicated references but warns the user before doing so.
> On 1/4/19 18:49, Luciano Rossi wrote:
> Instead of check the duplicate on party.id, could we validate on tax identifier? We could add to the system two party, but with the same tax identifier.
Good point! I've just modified the review to test the party_tax_identifier if set, otherwise we fallback to testing the same party.
I've also used a property to define the domain used to search duplicated invoices, so third party modules can customize the behavior if needed.On 2019-04-02 09:04, Sergi Almacellas Abellana wrote:
> > Cédric Krier added the comment:
> >
> > I do not think a warning is the right way because it prevents automatic creation of document.
> I've added a context flag that allows to skip the test. This can be set on automatic processes to skip the warning and create the documents.
This is not a good solution. We have seen that such design is broken
with the access right. Because it leads to have to set *everywhere* this
context if we want to be modular.
> > But here as the data is not controlled by Tryton, we can not guess that the reference will be unique per party.
> That's why I set it as warning so the system allows to include duplicated references but warns the user before doing so.
I doubt it adds real value for some reasons:
* Tools will never fix human workflow errors.
* Supplier invoices are assembled from purchase so already you cannot
use twice the same line.
* User will stop filling the reference field to avoid the warning.review265201002 updated at https://codereview.tryton.org/265201002/#ps249211002
> * Supplier invoices are assembled from purchase so already you cannot
use twice the same line.
But there are some invoices that do not come for any purchase. I.E: Internet, Phone, Water, Electricity, etc.
> * User will stop filling the reference field to avoid the warning.
Then we can should make it required to avoid the user skiping the warning.
As far as each customer invoice should have a number, each supplier invoice should have the external reference set.
But if we make the field required I'm wondering if we should make the feature an optin so it may be deactivated when the validation is not desired.On 2020-07-24 16:34, Sergi Almacellas Abellana wrote:
> > * Supplier invoices are assembled from purchase so already you cannot
> use twice the same line.
>
> But there are some invoices that do not come for any purchase. I.E: Internet, Phone, Water, Electricity, etc.
That's not a reason to disqualifies all other points.
> > * User will stop filling the reference field to avoid the warning.
>
> Then we can should make it required to avoid the user skiping the warning.
That's not possible. We can not assume that all supplier invoices
encoded will have a reference. And this is against Tryton principal to
not add constraint which are not required by the process.
For me a better solution needs to be found.We can not assume that all supplier invoices encoded will have a reference.
Why not? I think it is a good practices to set the supplier number as reference on the supplier invoices to encode the invoices. When receiving an invoice from a supplier you will always have a number as this is a mandatory field to have an invoice.
Do you have any example where the invoice should not have any number?
For me a better solution needs to be found.
I'm open to any other ideas if there is other.
review265201002 updated at https://codereview.tryton.org/265201002/#ps354491002
review265201002 updated at https://codereview.tryton.org/265201002/#ps384041005
review265201002 updated at https://codereview.tryton.org/265201002/#ps373041002
review265201002 updated at https://codereview.tryton.org/265201002/#ps393501002
New changeset 38d21c5755e2 by Cédric Krier in branch 'default':
Raise a warning when posting supplier invoice with same reference
https://hg.tryton.org/modules/account_invoice/rev/38d21c5755e2New changeset 62d357401813 by Cédric Krier in branch 'default':
Raise a warning when posting supplier invoice with same reference
https://hg.tryton.org/tryton-env/rev/62d357401813
