Tryton - Issues

 

Issue8122

Title Improve note button
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components sao, tryton, trytond
Assigned To ced Keywords review
Reviews 70561002
View: 70561002

Created on 2019-02-15.17:25:33 by ced, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
sao-resources-notification.png ced, 2019-02-15.17:34:15 image/png
tryton-resources-notification.png ced, 2019-02-15.17:34:07 image/png
tryton-resources-notification.png ced, 2019-02-17.01:10:10 image/png
Messages
New changeset 0db2c5a50f1e by Cédric Krier in branch 'default':
Improve note button
https://hg.tryton.org/tryton-env/rev/0db2c5a50f1e
New changeset d1851fde50bc by Cédric Krier in branch 'default':
Improve note button
https://hg.tryton.org/trytond/rev/d1851fde50bc
New changeset 65aff6f1a7e9 by Cédric Krier in branch 'default':
Improve note button
https://hg.tryton.org/tryton/rev/65aff6f1a7e9
New changeset 8986400587f5 by Cédric Krier in branch 'default':
Improve note button
https://hg.tryton.org/sao/rev/8986400587f5
review70561002 updated at https://codereview.tryton.org/70561002/#ps273101002
review70561002 updated at https://codereview.tryton.org/70561002/#ps120001
review70561002 updated at https://codereview.tryton.org/70561002/#ps100001
msg47080 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-02-17.01:10:10
I updated the review for tryton because on a second thought I think using red to notify presence of resource will be too distracted. It should be red only when there is something for the user like unread note. So I put two extra colors for icon which provide a gradient of importance.
review70561002 updated at https://codereview.tryton.org/70561002/#ps40001
review70561002 updated at https://codereview.tryton.org/70561002/#ps20001
review70561002 updated at https://codereview.tryton.org/70561002/#ps1
msg47063 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-02-15.17:34:07
Here is how it looks
msg47062 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-02-15.17:25:33
There are many points that can be improved:

- We could merge the call for ir.attachment and ir.note
- We could show also the number of note (in addition to the unread)
- tryton is missing any visual hint about note
History
Date User Action Args
2019-03-22 12:17:01roundup-botsetmessages: + msg47782
2019-03-22 12:16:59roundup-botsetmessages: + msg47781
2019-03-22 12:16:57roundup-botsetmessages: + msg47780
2019-03-22 12:16:53roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg47779
2019-03-15 12:08:50reviewbotsetmessages: + msg47608
2019-02-26 17:09:30reviewbotsetmessages: + msg47230
2019-02-22 10:09:26reviewbotsetmessages: + msg47153
2019-02-17 01:10:10cedsetfiles: + tryton-resources-notification.png
messages: + msg47080
2019-02-15 19:46:33reviewbotsetmessages: + msg47068
2019-02-15 18:47:47reviewbotsetmessages: + msg47065

Showing 10 items. Show all history (warning: this could be VERY long)