Tryton - Issues

 

Issue8037

Title Refactor Model.fields_get
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type performance Components GIS, trytond
Assigned To ced Keywords review
Reviews 74441002,58501002
View: 74441002, 58501002

Created on 2019-01-24.12:18:11 by ced, last changed by ced.

Messages
New changeset 500e58292c07 by Cédric Krier in branch 'default':
Fill add_remove definition only if it is not None
https://hg.tryton.org/tryton-env/rev/500e58292c07
New changeset 6d38b40b1e2d by Cédric Krier in branch 'default':
Fill add_remove definition only if it is not None
https://hg.tryton.org/trytond/rev/6d38b40b1e2d
New changeset 252b5672bdc3 by Cédric Krier in branch 'default':
Fill size definition only if it is not None
https://hg.tryton.org/tryton-env/rev/252b5672bdc3
New changeset 448e90dbd0ee by Cédric Krier in branch 'default':
Fill size definition only if it is not None
https://hg.tryton.org/trytond/rev/448e90dbd0ee
New changeset 7f7e8a0b86b0 by Cédric Krier in branch 'default':
Fill relation_field definition only with real field name
https://hg.tryton.org/tryton-env/rev/7f7e8a0b86b0
New changeset 043347298837 by Cédric Krier in branch 'default':
Fill relation_field definition only with real field name
https://hg.tryton.org/trytond/rev/043347298837
New changeset 37433efe75f6 by Cédric Krier in branch 'default':
Move field definition from Model to Field
https://hg.tryton.org/tryton-env/rev/37433efe75f6
New changeset 0c2774c03e70 by Cédric Krier in branch 'default':
Add field definition
https://hg.tryton.org/trytond-gis/rev/0c2774c03e70
New changeset 1094d993d89c by Cédric Krier in branch 'default':
Move field definition from Model to Field
https://hg.tryton.org/trytond/rev/1094d993d89c
review58501002 updated at https://codereview.tryton.org/58501002/#ps40001
review58501002 updated at https://codereview.tryton.org/58501002/#ps20001
review58501002 updated at https://codereview.tryton.org/58501002/#ps1
review74441002 updated at https://codereview.tryton.org/74441002/#ps1
msg46213 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-01-24.12:18:11
This method is very big and contains a lot of exception and test about the field type etc.
I think it will be more flexible, modular and readable that each field computes its definition.
History
Date User Action Args
2019-02-28 10:04:39cedsetcomponent: + GIS
2019-02-18 17:03:22roundup-botsetmessages: + msg47088
2019-02-18 17:03:18roundup-botsetmessages: + msg47087
2019-02-13 13:58:57roundup-botsetmessages: + msg47014
2019-02-13 13:58:52roundup-botsetmessages: + msg47013
2019-02-13 11:38:25roundup-botsetmessages: + msg47004
2019-02-13 11:38:20roundup-botsetmessages: + msg47003
2019-02-13 10:38:24roundup-botsetmessages: + msg46979
2019-02-13 10:38:21roundup-botsetmessages: + msg46978
2019-02-13 10:38:16roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg46977

Showing 10 items. Show all history (warning: this could be VERY long)