Tryton - Issues

 

Issue7915

Title Add date to pay lines wizard
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot, semarie
Type feature request Components account_payment
Assigned To ced Keywords review
Reviews 51591002
View: 51591002

Created on 2018-12-10.17:03:54 by ced, last changed by roundup-bot.

Messages
New changeset cb9c6875a166 by Cédric Krier in branch 'default':
Update test scenario to new pay wizard states
https://hg.tryton.org/tryton-env/rev/cb9c6875a166
New changeset 2ef0296f0cb3 by Cédric Krier in branch 'default':
Update test scenario to new pay wizard states
https://hg.tryton.org/modules/account_payment_clearing/rev/2ef0296f0cb3
New changeset fd41ce92f1c0 by Cédric Krier in branch 'default':
Add date to Pay Lines wizard
https://hg.tryton.org/tryton-env/rev/fd41ce92f1c0
New changeset 9820cc1404e6 by Cédric Krier in branch 'default':
Add date to Pay Lines wizard
https://hg.tryton.org/modules/account_payment/rev/9820cc1404e6
msg45269 (view) Author: [hidden] (semarie) Date: 2018-12-11.18:56:10
thanks, it makes sens
msg45265 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-12-11.18:11:14
There are two views because the ask journal view is part of a loop so it can be display multiple times. I do not think we want to ask multiple times the date.
The button is labelled "Pay" because it can be the last action of the wizard depending if there are or not a journal. This is computed on the transition so we can not show a different label before the transition. So I think it is better to always display as if it was the last action than the opposite and being the last action.
msg45264 (view) Author: [hidden] (semarie) Date: 2018-12-11.18:02:32
just two remarks (mostly cosmetic, so feel free to disregard them)

1. why having two views ? one for asking the date, and another for asking the journal ? isn't more simple to have both on the same view ? it would be only two/three lines in total.

2. with wizard in two views, the "next" button for PayLineStart is labelled "Pay", as if the next action will be effectively the Payment creation. I found it is a bit confusing from UI point of vue as the result is asking the journal. A "Next" button would be more straightfull. But I didn't check how are done others multiviews wizards.
review51591002 updated at https://codereview.tryton.org/51591002/#ps20001
review51591002 updated at https://codereview.tryton.org/51591002/#ps1
msg45233 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-12-10.17:03:54
With issue5888, we lost the date added by issue4921.
I think we should reintroduce it as it help user to plan in advance the payments more easily.
History
Date User Action Args
2019-01-17 19:25:52roundup-botsetmessages: + msg46047
2019-01-17 19:25:45roundup-botsetmessages: + msg46046
2019-01-17 17:19:43roundup-botsetmessages: + msg46017
2019-01-17 17:19:36roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg46016
2018-12-11 18:56:10semariesetmessages: + msg45269
2018-12-11 18:11:14cedsetmessages: + msg45265
2018-12-11 18:02:32semariesetnosy: + semarie
messages: + msg45264
2018-12-11 15:09:28reviewbotsetmessages: + msg45262
2018-12-10 17:17:49reviewbotsetnosy: + reviewbot
messages: + msg45234
2018-12-10 17:04:38cedsetstatus: in-progress -> testing
reviews: 51591002
keyword: + review

Showing 10 items. Show all history (warning: this could be VERY long)