Tryton - Issues

 

Issue7878

Title Do not allow to search or sort on ModelView only
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type crash Components trytond
Assigned To ced Keywords review
Reviews 56491002
View: 56491002

Created on 2018-11-22.17:50:35 by ced, last changed by roundup-bot.

Messages
New changeset d6d4842f34b2 by Cédric Krier in branch '5.0':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/trytond/rev/d6d4842f34b2

New changeset 344a525569eb by Cédric Krier in branch '4.8':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/trytond/rev/344a525569eb

New changeset 40df532bd9bc by Cédric Krier in branch '4.6':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/trytond/rev/40df532bd9bc

New changeset aa3fb5b848bc by Cédric Krier in branch '4.4':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/trytond/rev/aa3fb5b848bc

New changeset cf2701d71734 by Cédric Krier in branch '4.2':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/trytond/rev/cf2701d71734
New changeset 1b27bdf86366 by Cédric Krier in branch 'default':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/tryton-env/rev/1b27bdf86366
New changeset 517ffd25f880 by Cédric Krier in branch 'default':
Disable sortable and searchable on ModelView only
https://hg.tryton.org/trytond/rev/517ffd25f880
review56491002 updated at https://codereview.tryton.org/56491002/#ps1
msg44981 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-11-22.17:50:34
For ModelView only, the attribute of the fields sortable and searchable can be set to True. So if such model is display on a tree view, the client can emit a search request which will crash as it is not a ModelStorage.
So for me, we should disable those attributes if the Model does not have a search method.
History
Date User Action Args
2018-12-30 19:39:16roundup-botsetmessages: + msg45637
2018-12-17 23:03:38roundup-botsetmessages: + msg45366
2018-12-17 23:03:34roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg45365
2018-11-22 18:06:27reviewbotsetnosy: + reviewbot
messages: + msg44982
2018-11-22 17:51:45cedsetstatus: in-progress -> testing
reviews: 56491002
keyword: + review
2018-11-22 17:50:35cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)