Tryton - Issues

 

Issue7830

Title Remove read all fields
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type performance Components trytond
Assigned To ced Keywords review
Reviews 54421002
View: 54421002

Created on 2018-11-01.18:47:54 by ced, last changed by roundup-bot.

Messages
New changeset f2395405572b by Cédric Krier in branch 'default':
Remove implicit fields names in Dashboard.read
https://hg.tryton.org/tryton-env/rev/f2395405572b
New changeset 2e5cee4da2b3 by Cédric Krier in branch 'default':
Remove implicit fields names in Dashboard.read
https://hg.tryton.org/modules/dashboard/rev/2e5cee4da2b3
New changeset df770d5f4138 by Cédric Krier in branch 'default':
Remove implicit fields names in ModelStorage.read
https://hg.tryton.org/tryton-env/rev/df770d5f4138
New changeset bfef7a2472b2 by Cédric Krier in branch 'default':
Remove implicit fields names in ModelStorage.read
https://hg.tryton.org/trytond/rev/bfef7a2472b2
review54421002 updated at https://codereview.tryton.org/54421002/#ps20001
review54421002 updated at https://codereview.tryton.org/54421002/#ps1
msg44714 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-11-01.18:47:54
I just found that the same code is duplicated in ModelStorage and ModelSQL, it fills the fields_names when not set. This makes me re-think about this behavior. Indeed it should be considered as a bad practice and performance killer to read all the fields like that. clients nor proteus do such think.
So I propose to remove this behavior and force user to always list the fields read.
History
Date User Action Args
2018-12-20 21:21:52roundup-botsetmessages: + msg45420
2018-12-20 21:21:49roundup-botsetmessages: + msg45419
2018-11-28 10:05:20roundup-botsetmessages: + msg45059
2018-11-28 10:05:14roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg45058
2018-11-18 17:37:15reviewbotsetmessages: + msg44919
2018-11-01 18:53:15reviewbotsetnosy: + reviewbot
messages: + msg44715
2018-11-01 18:49:00cedsetstatus: in-progress -> testing
reviews: 54421002
keyword: + review
2018-11-01 18:47:54cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)