Tryton - Issues

 

Issue7830

Title Remove read all fields
Priority feature Status testing
Superseder Nosy List ced, reviewbot
Type performance Components trytond
Assigned To ced Keywords review
Reviews 54421002
View: 54421002

Created on 2018-11-01.18:47:54 by ced, last changed by reviewbot.

Messages
review54421002 updated at https://codereview.tryton.org/54421002/#ps1
msg44714 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-11-01.18:47:54
I just found that the same code is duplicated in ModelStorage and ModelSQL, it fills the fields_names when not set. This makes me re-think about this behavior. Indeed it should be considered as a bad practice and performance killer to read all the fields like that. clients nor proteus do such think.
So I propose to remove this behavior and force user to always list the fields read.
History
Date User Action Args
2018-11-01 18:53:15reviewbotsetnosy: + reviewbot
messages: + msg44715
2018-11-01 18:49:00cedsetstatus: in-progress -> testing
reviews: 54421002
keyword: + review
2018-11-01 18:47:54cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)