Tryton - Issues

 

Issue7795

Title Tax code line values are not updated from template
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type behavior Components account
Assigned To pokoli Keywords review
Reviews 51561002
View: 51561002

Created on 2018-10-18.17:40:56 by pokoli, last changed by roundup-bot.

Messages
New changeset 25da5477f732 by Sergi Almacellas Abellana in branch '5.0':
Update tax code lines when updating chart from template
https://hg.tryton.org/modules/account/rev/25da5477f732

New changeset 0ce66e56d763 by Sergi Almacellas Abellana in branch '4.8':
Update tax code lines when updating chart from template
https://hg.tryton.org/modules/account/rev/0ce66e56d763
New changeset 7afdf93eb0b5 by Sergi Almacellas Abellana in branch 'default':
Update tax code lines when updating chart from template
https://hg.tryton.org/tryton-env/rev/7afdf93eb0b5
New changeset 98c3e872f0c0 by Sergi Almacellas Abellana in branch 'default':
Update tax code lines when updating chart from template
https://hg.tryton.org/modules/account/rev/98c3e872f0c0
review51561002 updated at https://codereview.tryton.org/51561002/#ps80001
review51561002 updated at https://codereview.tryton.org/51561002/#ps60001
review51561002 updated at https://codereview.tryton.org/51561002/#ps40001
review51561002 updated at https://codereview.tryton.org/51561002/#ps20001
msg44470 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-10-18.19:16:43
I've updated the review including a update chart test that catches the error. 

I tried to pick a good compromise between features tested and test case size, trying to keep the test simple but testing most of the features.
review51561002 updated at https://codereview.tryton.org/51561002/#ps1
msg44466 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-18.17:45:58
It is probably time to write tests for the update of chart of account.
msg44465 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-10-18.17:40:55
When testing issue7789 I've just noticed that the tax code lines are not updated when updating the chart of accounts.

The wizard runs without problems but the values are not updated
History
Date User Action Args
2018-11-25 10:47:49cedlinkissue7801 superseder
2018-10-23 19:30:58roundup-botsetmessages: + msg44537
2018-10-22 11:34:39roundup-botsetmessages: + msg44516
2018-10-22 11:34:29roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg44515
2018-10-20 19:29:27reviewbotsetmessages: + msg44492
2018-10-19 17:27:35reviewbotsetmessages: + msg44488
2018-10-19 16:59:22reviewbotsetmessages: + msg44485
2018-10-18 19:23:05reviewbotsetmessages: + msg44471
2018-10-18 19:16:43pokolisetmessages: + msg44470
2018-10-18 17:58:41reviewbotsetnosy: + reviewbot
messages: + msg44467

Showing 10 items. Show all history (warning: this could be VERY long)