Tryton - Issues

 

Issue7791

Title New taxes on account template are not added to account on account chart update
Priority bug Status in-progress
Superseder Nosy List Timitos, ced, pokoli, reviewbot
Type behavior Components account
Assigned To Timitos Keywords review
Reviews 72351002,49641002
View: 72351002, 49641002

Created on 2018-10-17.13:46:12 by Timitos, last changed by pokoli.

Messages
msg44491 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-10-20.18:59:33
I've added the test on issue7801 and included a tax on an account to test this scenario.
msg44487 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-19.17:09:07
Probably, I propose @pokoli that you move your test in a new issue and include test this case.
msg44486 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-10-19.17:01:36
I'm wondering if we should also test this case on the update_chart of review51561002
review49641002 updated at https://codereview.tryton.org/49641002/#ps20001
msg44483 (view) Author: [hidden] (Timitos) Date: 2018-10-19.15:28:19
This is the review for trunk:
review49641002
msg44458 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-18.14:01:01
Could you provide a patch for trunk as for me it the higher version affected.
msg44443 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-17.15:12:29
OK, the title is not very accurate. Also I do not see why it is a crash? for me, it looks like a behavior issue. Also can you assign and set the status of the issue to you if you are working on it.
msg44441 (view) Author: [hidden] (Timitos) Date: 2018-10-17.14:37:21
If you have an account template that does not have taxes set on chart creation. Then you add a tax on this template and then execute the "Update chart of accounts from template" wizard. Then the new tax is not added to the account.
msg44440 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-17.13:49:59
I do not understand. What is the problem?
msg44439 (view) Author: [hidden] (Timitos) Date: 2018-10-17.13:49:24
This review fixes the problem:
review72351002
msg44438 (view) Author: [hidden] (Timitos) Date: 2018-10-17.13:46:11
In at least version 4.8 account taxes of template cannot be copied to account on chart creation.
History
Date User Action Args
2018-10-20 18:59:34pokolisetmessages: + msg44491
2018-10-19 17:09:08cedsetmessages: + msg44487
2018-10-19 17:01:36pokolisetnosy: + pokoli
messages: + msg44486
2018-10-19 16:00:40reviewbotsetnosy: + reviewbot
messages: + msg44484
2018-10-19 15:28:19Timitossetreviews: 72351002 -> 72351002,49641002
messages: + msg44483
2018-10-18 14:01:01cedsetmessages: + msg44458
2018-10-17 15:58:52Timitossettitle: Add action of many2many takes a list of ids in update_account_taxes -> New taxes on account template are not added to account on account chart update
2018-10-17 15:36:40Timitossetstatus: chatting -> in-progress
assignedto: Timitos
2018-10-17 15:36:08Timitossettype: crash -> behavior
2018-10-17 15:12:29cedsetmessages: + msg44443

Showing 10 items. Show all history (warning: this could be VERY long)