New taxes on account template are not added to account on account chart update
In at least version 4.8 account taxes of template cannot be copied to account on chart creation.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Korbinian Preisler added accounting type::crash + 1 deleted label
added accounting type::crash + 1 deleted label
- Author Developer
This review fixes the problem:
review72351002 - Korbinian Preisler added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Owner
I do not understand. What is the problem?
- Author Developer
If you have an account template that does not have taxes set on chart creation. Then you add a tax on this template and then execute the "Update chart of accounts from template" wizard. Then the new tax is not added to the account.
- Owner
OK, the title is not very accurate. Also I do not see why it is a crash? for me, it looks like a behavior issue. Also can you assign and set the status of the issue to you if you are working on it.
- Korbinian Preisler added type::behavior label and removed type::crash label
added type::behavior label and removed type::crash label
- Korbinian Preisler assigned to @timitos
assigned to @timitos
- Korbinian Preisler added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Owner
Could you provide a patch for trunk as for me it the higher version affected.
- Author Developer
This is the review for trunk:
review49641002 review49641002 updated at https://codereview.tryton.org/49641002/#ps20001
- Developer
I'm wondering if we should also test this case on the update_chart of review51561002
- Owner
Probably, I propose @pokoli that you move your test in a new issue and include test this case.
- Developer
I've added the test on #7801 (closed) and included a tax on an account to test this scenario.
- Author Developer
For me it is not clear how to proceed with this issue.
I know that first a patch for trunk is needed that can be backported. Should this go into a new review or into one of the existing ones? - Owner
Following my comments on review49641002, the review72351002 was correct so I will commit it on trunk.
- Owner
FYI, I tested it (with #7718 (closed)) with the test from #7801 (closed) and by upgrading the b2ck database with Belgium taxes which removed many taxes.
- Owner
Also it was a crash because the API for add on one2many requires a list of ids instead of single id.
- Cédric Krier added type::crash label and removed type::behavior label
added type::crash label and removed type::behavior label