Created on 2018-10-05.00:26:19 by ced, last changed 1 month ago by roundup-bot.
New changeset d5ee4e0cc24b by Cédric Krier in branch 'default': Skip access check on ModelStorage instances https://hg.tryton.org/tryton-env/rev/d5ee4e0cc24b
New changeset 982a131026e7 by Cédric Krier in branch 'default': Skip access check on ModelStorage instances https://hg.tryton.org/trytond/rev/982a131026e7
Indeed it is a more than a performance issue because on ModelView.button the decorated function is called with
_check_access disabled but the
records instances have still the
_check_access context. So if
save are called on the records for a field that user has no access, an error is raised even if she has access right to trigger the button.
I think in order to avoid future similar issue than issue7764, we could remove check_access from the context when instantiate a record. The rational is that instance can only be accessed from the code running on the server and as we have the design to check access at the border/entry point, so access from instances does not need to be checked.
|2020-12-18 00:09:27||roundup-bot||set||messages: + msg63335|
nosy: + roundup-bot
status: testing -> resolved
|2020-11-17 12:16:44||reviewbot||set||messages: + msg61984|
nosy: + reviewbot
status: in-progress -> testing
status: unread -> in-progress
type: performance -> behavior
|2018-10-05 00:41:44||ced||set||assignedto: ced|
Showing 10 items. Show all history (warning: this could be VERY long)