Tryton - Issues

 

Issue7570

Title Do not use free product for promotion
Priority feature Status testing
Superseder Nosy List ced, reviewbot
Type behavior Components sale_promotion
Assigned To ced Keywords review
Reviews 58331002
View: 58331002

Created on 2018-07-10.12:19:56 by ced, last changed by reviewbot.

Messages
review58331002 updated at https://codereview.tryton.org/58331002/#ps1
msg42117 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-10.12:19:56
A product with a unit price of zero should never have a promotion applied. Also most of the time, it will prevent the promotion to apply because the price with promotion will not be lower than zero.
So for me, such free product (ex: from sale_extra) should not be considered for the application of the promotion.
History
Date User Action Args
2018-07-10 12:44:26reviewbotsetnosy: + reviewbot
messages: + msg42120
2018-07-10 12:26:31cedsetstatus: in-progress -> testing
reviews: 58331002
keyword: + review
2018-07-10 12:19:56cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)