Tryton - Issues

 

Issue7564

Title Increase height of Selection in search box
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components tryton
Assigned To ced Keywords review
Reviews 72271002
View: 72271002

Created on 2018-07-06.16:51:45 by ced, last changed by roundup-bot.

Messages
New changeset c32e77985fe3 by Cédric Krier in branch 'default':
Set minimal and maximal height for Selection in search box
https://hg.tryton.org/tryton-env/rev/c32e77985fe3
New changeset 2e5f5c59836e by Cédric Krier in branch 'default':
Set minimal and maximal height for Selection in search box
https://hg.tryton.org/tryton/rev/2e5f5c59836e
review72271002 updated at https://codereview.tryton.org/72271002/#ps1
msg42086 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-06.16:52:58
Here is review72271002. I chose arbitrary values which I find work well.
msg42084 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-06.16:51:44
The ScrolledWindow has a default minimal height that shows at least two options. This does not give the hint to the user that more values are available. The height should depend on the number of options.
Since GTK3 switch, we have now access to new functions:
https://developer.gnome.org/gtk3/stable/GtkScrolledWindow.html#gtk-scrolled-window-set-min-content-height
https://developer.gnome.org/gtk3/stable/GtkScrolledWindow.html#gtk-scrolled-window-set-max-content-width

We could set a minimal height depending on the number of options and a fixed maximal height.
History
Date User Action Args
2018-07-24 19:18:26roundup-botsetmessages: + msg42285
2018-07-24 19:18:23roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg42284
2018-07-06 17:17:36reviewbotsetnosy: + reviewbot
messages: + msg42088
2018-07-06 16:52:59cedsetstatus: in-progress -> testing
reviews: 72271002
messages: + msg42086
keyword: + review
2018-07-06 16:51:45cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)