Tryton - Issues

 

Issue7563

Title Use GtkApplication
Priority feature Status testing
Superseder Nosy List Timitos, ced, pokoli, reviewbot
Type feature request Components tryton
Assigned To ced Keywords review
Reviews 48521002
View: 48521002

Created on 2018-07-06.14:49:03 by ced, last changed by reviewbot.

Messages
review48521002 updated at https://codereview.tryton.org/48521002/#ps120001
review48521002 updated at https://codereview.tryton.org/48521002/#ps100001
review48521002 updated at https://codereview.tryton.org/48521002/#ps80001
review48521002 updated at https://codereview.tryton.org/48521002/#ps60001
msg42104 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-09.10:09:24
We do not control where the application menu is placed. If the window manager support it, the application menu is on the global menu (OSX, Unity etc.).
msg42097 (view) Author: [hidden] (Timitos) Date: 2018-07-06.20:16:45
Why not putting the preferences icon to the right beside the window controls and place the icon to hide the menu to the far left like in the webclient?
msg42089 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-06.17:30:06
On 2018-07-06 16:55, Sergi Almacellas Abellana wrote:
> I find that the preferences menu it's a little bit hidden. I'm wondering if we should mimic sao and allow to open user preferences by clicking on the title. Probably not only the preferences but all the current menu. 

It is not really possible with GtkHeaderBar without loosing the subtitle.
Also the menu may be deported depending of the desktop.

> The icon to hide menu is inside of the search bar which makes dificult to understand that it is related to the menu. 

I think it is only because the icon is not right. A better one will be
used when switching to Material https://discuss.tryton.org/t/new-theme-icon-for-tryton/507
msg42087 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-07-06.16:55:52
Wow, the application looks more modern now. 

I find that the preferences menu it's a little bit hidden. I'm wondering if we should mimic sao and allow to open user preferences by clicking on the title. Probably not only the preferences but all the current menu. 

The icon to hide menu is inside of the search bar which makes dificult to understand that it is related to the menu. 

I like the new connection workflow as the application is not shown until connected which makes sense instead of showing an empty application. I feel that closing the application to disconect more intuitive than allowing to disconnect.
review48521002 updated at https://codereview.tryton.org/48521002/#ps40001
review48521002 updated at https://codereview.tryton.org/48521002/#ps1
msg42080 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-06.15:02:46
Here is review48521002

The connection workflow is a little bit changed. As GtkApplication use ID to make instances unique, we ask for connection before starting. If an application with the same ID is already running, the command actions are sent to it (like IPC but managed by GTK). This communication does not work on OSX for now, so multiple instance can be launched.
It is no more possible to disconnect and change the connection of a running instance (ID can not be changed). So the user must close the application.

The save of the window size is also removed because it was not reliable with the GtkHeaderBar. Instead the window try to always start maximized.
msg42079 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-06.14:49:03
To have a "croos-platform" notification system, we need to use GtkApplication: https://discuss.tryton.org/t/real-time-notification/224/21
History
Date User Action Args
2018-07-21 18:01:48reviewbotsetmessages: + msg42239
2018-07-20 16:02:37reviewbotsetmessages: + msg42223
2018-07-11 17:21:25reviewbotsetmessages: + msg42145
2018-07-10 18:14:37reviewbotsetmessages: + msg42137
2018-07-09 10:09:25cedsetmessages: + msg42104
2018-07-06 20:16:46Timitossetmessages: + msg42097
2018-07-06 17:30:06cedsetmessages: + msg42089
2018-07-06 16:55:53pokolisetnosy: + pokoli
messages: + msg42087
2018-07-06 16:52:06reviewbotsetmessages: + msg42085
2018-07-06 15:10:23reviewbotsetnosy: + reviewbot
messages: + msg42082

Showing 10 items. Show all history (warning: this could be VERY long)