Server / client notifications
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Nicolas Évrard assigned to @nicoe
assigned to @nicoe
- Nicolas Évrard added sao tryton trytond type::feature + 1 deleted label
added sao tryton trytond type::feature + 1 deleted label
New review60271002 at https://codereview.tryton.org/60271002/#ps1
review60271002 updated at https://codereview.tryton.org/60271002/#ps20001
New review66271002 at https://codereview.tryton.org/66271002/#ps20001
review66271002 updated at https://codereview.tryton.org/66271002/#ps40001
review60271002 updated at https://codereview.tryton.org/60271002/#ps40001
review60271002 updated at https://codereview.tryton.org/60271002/#ps60001
review66271002 updated at https://codereview.tryton.org/66271002/#ps60001
review60271002 updated at https://codereview.tryton.org/60271002/#ps80001
review66271002 updated at https://codereview.tryton.org/66271002/#ps100001
review66271002 updated at https://codereview.tryton.org/66271002/#ps120001
review60271002 updated at https://codereview.tryton.org/60271002/#ps100001
review60271002 updated at https://codereview.tryton.org/60271002/#ps120001
review66271002 updated at https://codereview.tryton.org/66271002/#ps140001
review60271002 updated at https://codereview.tryton.org/60271002/#ps140001
review60271002 updated at https://codereview.tryton.org/60271002/#ps160001
review60271002 updated at https://codereview.tryton.org/60271002/#ps180001
review60271002 updated at https://codereview.tryton.org/60271002/#ps200001
review66271002 updated at https://codereview.tryton.org/66271002/#ps160001
review66271002 updated at https://codereview.tryton.org/66271002/#ps180001
review60271002 updated at https://codereview.tryton.org/60271002/#ps220001
review60271002 updated at https://codereview.tryton.org/60271002/#ps240001
review66271002 updated at https://codereview.tryton.org/66271002/#ps200001
review60271002 updated at https://codereview.tryton.org/60271002/#ps260001
review60271002 updated at https://codereview.tryton.org/60271002/#ps280001
review60271002 updated at https://codereview.tryton.org/60271002/#ps300001
review60271002 updated at https://codereview.tryton.org/60271002/#ps320001
review60271002 updated at https://codereview.tryton.org/60271002/#ps330001
- Owner
Why are all the reviews closed?
- Author Owner
* Cédric Krier [2018-08-09 23:03:35]:
> Why are all the reviews closed?
Because I made a global review: https://codereview.tryton.org/66341002/ - Developer
I do not have permisions to see review66341002
- Author Owner
* Sergi Almacellas Abellana [2018-08-10 11:53:28]:
> I do not have permisions to see review66341002
Indeed it was set as private.
Strange I used the script distributed by rietveld to upload it instead
of hg review obviously.
It should be fixed now. review66341002 updated at https://codereview.tryton.org/66341002/#ps1
- Developer
About the Bus.publish() method: I saw the documentation is saying it is permitted to notify *all* users (when `user` is `None`). Does some authorization is required or any user could (ab)use the Bus to spam others users ?
- Author Owner
* Sebastien Marie [2018-08-10 14:54:35]:
>
> Sebastien Marie <semarie-openbsd@latrappe.fr> added the comment:
>
> About the Bus.publish() method: I saw the documentation is saying it
> is permitted to notify *all* users (when `user` is `None`). Does
> some authorization is required or any user could (ab)use the Bus to
> spam others users ?
This method can only be called by module (through the notify function
for now others might be added later) so it's some code that has been
deployed on the server that would be abusing the system. So I don't
think there should be any special right to do this.
But I guess that the documentation is not clear enough so if you have
a proposition to better convey this I would be happy to add it in the
review. - Developer
ah yes, I see my mistake. only `subscribe` is globally accessible via a @route.
the documentation is fine. sorry for the noise. - Author Owner
* Sebastien Marie [2018-08-10 16:17:43]:
> the documentation is fine.
OK Good.
> sorry for the noise.
NP it's always good to have some feedback. review66341002 updated at https://codereview.tryton.org/66341002/#ps20001
review66341002 updated at https://codereview.tryton.org/66341002/#ps40001
review66341002 updated at https://codereview.tryton.org/66341002/#ps60001
review66341002 updated at https://codereview.tryton.org/66341002/#ps80001
review66341002 updated at https://codereview.tryton.org/66341002/#ps100001
review66341002 updated at https://codereview.tryton.org/66341002/#ps120001
review66341002 updated at https://codereview.tryton.org/66341002/#ps140001
review66341002 updated at https://codereview.tryton.org/66341002/#ps160001
review66341002 updated at https://codereview.tryton.org/66341002/#ps180001
review66341002 updated at https://codereview.tryton.org/66341002/#ps200001
review66341002 updated at https://codereview.tryton.org/66341002/#ps220001
review66341002 updated at https://codereview.tryton.org/66341002/#ps260001
New changeset 24d7407ed47a by Nicolas ?vrard in branch 'default':
Add bus management
https://hg.tryton.org/sao/rev/24d7407ed47a- Roundup Robot added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label
- Roundup Robot closed
closed
New changeset dfac5ee59e60 by Nicolas ?vrard in branch 'default':
Add bus management
https://hg.tryton.org/tryton/rev/dfac5ee59e60New changeset 6d62f513f177 by Nicolas ?vrard in branch 'default':
Add bus management
https://hg.tryton.org/trytond/rev/6d62f513f177New changeset 1decbef5d7ed by Nicolas ?vrard in branch 'default':
Add bus management
https://hg.tryton.org/tryton-env/rev/1decbef5d7ed- Cédric Krier mentioned in issue #10099 (closed)
mentioned in issue #10099 (closed)