Tryton - Issues

 

Issue7417

Title Better support for chart of account evolution over time
Priority feature Status testing
Superseder Nosy List Timitos, ced, pokoli, reviewbot
Type feature request Components account
Assigned To ced Keywords review
Reviews 45671002
View: 45671002

Created on 2018-05-05.18:35:30 by ced, last changed by reviewbot.

Messages
review45671002 updated at https://codereview.tryton.org/45671002/#ps20001
review45671002 updated at https://codereview.tryton.org/45671002/#ps1
msg42234 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-21.15:34:17
Here is the new review45671002 with subrepo.
msg42050 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-03.15:10:05
On 2018-07-03 13:11, Korbinian Preisler wrote:
> account/view/account_list.xml should get an active field to allow to search for inactive accounts. I think it is necessary to be able to edit inactive accounts.

It is no more needed since changeset 0856eb077b1c

On 2018-07-03 13:26, Korbinian Preisler wrote:
> account_invoice review is missing a solution to handle account switch if the accounting or invoice date is changed after lines have been entered already

I do not think it is a case to manage. Indeed for me, invoice is a
operational data so it should do what is recorded unlike referential
data which store data for long term.
msg42049 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-07-03.15:03:40
> account/view/account_list.xml should get an active field to allow to search for inactive accounts. I think it is necessary to be able to edit inactive accounts.

This should be automatically managed on client side with the new active widget that we added for version 4.8
msg42045 (view) Author: [hidden] (Timitos) Date: 2018-07-03.13:26:30
account_invoice review is missing a solution to handle account switch if the accounting or invoice date is changed after lines have been entered already
msg42044 (view) Author: [hidden] (Timitos) Date: 2018-07-03.13:11:09
account/view/account_list.xml should get an active field to allow to search for inactive accounts. I think it is necessary to be able to edit inactive accounts.
review58301002 updated at https://codereview.tryton.org/58301002/#ps40001
review62281002 updated at https://codereview.tryton.org/62281002/#ps1
review70261002 updated at https://codereview.tryton.org/70261002/#ps1
review62271002 updated at https://codereview.tryton.org/62271002/#ps1
review58311002 updated at https://codereview.tryton.org/58311002/#ps20001
review64271002 updated at https://codereview.tryton.org/64271002/#ps1
review52401002 updated at https://codereview.tryton.org/52401002/#ps1
review50501002 updated at https://codereview.tryton.org/50501002/#ps20001
review48501002 updated at https://codereview.tryton.org/48501002/#ps1
review58301002 updated at https://codereview.tryton.org/58301002/#ps20001
review62281002 updated at https://codereview.tryton.org/62281002/#ps1
review70261002 updated at https://codereview.tryton.org/70261002/#ps1
review62271002 updated at https://codereview.tryton.org/62271002/#ps1
review58311002 updated at https://codereview.tryton.org/58311002/#ps20001
review64271002 updated at https://codereview.tryton.org/64271002/#ps1
review52401002 updated at https://codereview.tryton.org/52401002/#ps1
review50501002 updated at https://codereview.tryton.org/50501002/#ps20001
review48501002 updated at https://codereview.tryton.org/48501002/#ps1
review58301002 updated at https://codereview.tryton.org/58301002/#ps20001
review62281002 updated at https://codereview.tryton.org/62281002/#ps1
review70261002 updated at https://codereview.tryton.org/70261002/#ps1
review62271002 updated at https://codereview.tryton.org/62271002/#ps1
review58311002 updated at https://codereview.tryton.org/58311002/#ps20001
review64271002 updated at https://codereview.tryton.org/64271002/#ps1
review52401002 updated at https://codereview.tryton.org/52401002/#ps1
review50501002 updated at https://codereview.tryton.org/50501002/#ps20001
review48501002 updated at https://codereview.tryton.org/48501002/#ps1
review58301002 updated at https://codereview.tryton.org/58301002/#ps20001
review62281002 updated at https://codereview.tryton.org/62281002/#ps1
review70261002 updated at https://codereview.tryton.org/70261002/#ps1
review62271002 updated at https://codereview.tryton.org/62271002/#ps1
review64271002 updated at https://codereview.tryton.org/64271002/#ps1
review58311002 updated at https://codereview.tryton.org/58311002/#ps20001
review52401002 updated at https://codereview.tryton.org/52401002/#ps1
review50501002 updated at https://codereview.tryton.org/50501002/#ps20001
review48501002 updated at https://codereview.tryton.org/48501002/#ps1
review58301002 updated at https://codereview.tryton.org/58301002/#ps20001
New review62281002 at https://codereview.tryton.org/62281002/#ps1
New review70261002 at https://codereview.tryton.org/70261002/#ps1
New review62271002 at https://codereview.tryton.org/62271002/#ps1
New review64271002 at https://codereview.tryton.org/64271002/#ps1
review58311002 updated at https://codereview.tryton.org/58311002/#ps20001
New review52401002 at https://codereview.tryton.org/52401002/#ps1
msg41645 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-25.18:39:08
It is ready for testing.
review50501002 updated at https://codereview.tryton.org/50501002/#ps20001
New review48501002 at https://codereview.tryton.org/48501002/#ps1
review58301002 updated at https://codereview.tryton.org/58301002/#ps20001
msg41640 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-25.13:21:53
Indeed I found that I could reuse the update_account_taxes which is a second update loop to synchronize the "forward" field. So I will go this way because it will be simpler to understand for the user.
New review58311002 at https://codereview.tryton.org/58311002/#ps1
New review50501002 at https://codereview.tryton.org/50501002/#ps1
New review58301002 at https://codereview.tryton.org/58301002/#ps1
msg41601 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-06-22.19:30:25
Here is review58301002
It does not yet contain the "forward" feature because I'm not yet sure about the design. Having reference to other account on the account will complicate a lot the template creation/synchronization. So I'm thinking of using a different Model to store this information which will be synchronized after. This design will also allow to make more complex replacement rules (a little bit like the tax rules).
msg40526 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-05-05.18:35:29
For now, there is a single active check box which is only usable if no moves have ever been made on this account or its children.

But some countries (like Germany) have a highly evolving charts for almost every fiscal year. The 'active' field is not good enough as account should deactivated from a specific fiscal year.

Here is my proposal:

- Add a from/to date on the account (and template) (and enforce on children)
- Add a function field that convert the dates into valid fiscal years
- Enforce move creation inside the dates/fiscal year
- Compute active field using the dates/fiscal year/periods from the context
- Ensure that date/fiscal year/period are set in the search context for all document storing account
- Add a forward account field on account that have an end date. The property "account*used" must follow such forward until a valid account for the date is found.

The same design should be added also on the tax code and line (but not the forward).
History
Date User Action Args
2018-07-31 19:35:08reviewbotsetmessages: + msg42562
2018-07-21 15:42:45reviewbotsetmessages: + msg42237
2018-07-21 15:34:17cedsetreviews: 58301002, 50501002, 58311002, 48501002, 52401002, 64271002, 62271002, 70261002, 62281002 -> 45671002
messages: + msg42234
2018-07-03 15:10:06cedsetmessages: + msg42050
2018-07-03 15:03:41pokolisetmessages: + msg42049
2018-07-03 13:26:31Timitossetmessages: + msg42045
2018-07-03 13:11:10Timitossetmessages: + msg42044
2018-06-29 10:59:28reviewbotsetmessages: + msg41967
2018-06-26 23:27:02reviewbotsetmessages: + msg41866
2018-06-26 23:27:00reviewbotsetmessages: + msg41865

Showing 10 items. Show all history (warning: this could be VERY long)