Sale reporting does not return any result when no currency rates are available

I've created a new database and filled data using the demo script from tryton tools. I see the sales on the database but when opening the sale reporting (any report) it does not show any result.

added sales type::behavior + 1 deleted label

assigned to @pokoli

added 1 deleted label and removed 1 deleted label

I'm not sure if it is a bug. If there is not rate for the currency, it is probably better to not display value than display wrong values.

review46381002 updated at https://codereview.tryton.org/46381002/#ps1

I see your point and I agree that probably it's better to not display any instead of wrong values.

The issue is that no data is shown despite the sales use the company currency which does not require any conversion.

Normally, we have a default rate for euro in currency.xml
But maybe it should be improved by having a configuration wizard which ask what is the default currency and put a rate of 1 on it.

> Normally, we have a default rate for euro in currency.xml

This does not solve the problem as the database uses usd for company (and sales) currency.

> But maybe it should be improved by having a configuration wizard which ask what is the default currency and put a rate of 1 on it.

Probably, but for me this is a separate issue and won't fix this issue as the user may skip the configuration wizard.

So we can invalidate it.

> So we can invalidate it.

Why?

I've updated the review taking in account your comments. So when no currency rates are available zero amount is used and when the currency is the same as the company the 1.0 rate is used as no conversion is needed. For me this is the correct fix.

zero amount when rate is missing is still a value display that is wrong.
You just replaced a default rate of 1 by 0, it is still a guessing value.
I still prefer the current behavior.

review46381002 updated at https://codereview.tryton.org/46381002/#ps2

added 1 deleted label and removed 1 deleted label

closed