Tryton - Issues

 

Issue7245

Title Use table-layout fixed
Priority feature Status resolved
Superseder Nosy List ced, nicoe, reviewbot, roundup-bot
Type performance Components sao
Assigned To ced Keywords review
Reviews 37111002
View: 37111002

Created on 2018-03-21.11:28:14 by ced, last changed by roundup-bot.

Messages
New changeset 60d4cde3ed8f by Cédric Krier in branch 'default':
Ensure consistent treeview rendering by using fixed table-layout
http://hg.tryton.org/sao/rev/60d4cde3ed8f
review37111002 updated at https://codereview.tryton.org/37111002/#ps40001
review37111002 updated at https://codereview.tryton.org/37111002/#ps20001
msg39180 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-21.15:13:54
It should be fixed in last version.
msg39177 (view) Author: [hidden] (nicoe) (Tryton committer) (Tryton translator) Date: 2018-03-21.14:30:40
I tested it under chromium and it works but:
 - the calendar of an editable date column still does not pop up
 - the completion widget of a m2o does not appear either
review37111002 updated at https://codereview.tryton.org/37111002/#ps1
msg39160 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-21.11:31:44
Here is review37111002 thanks to test it on different browser to ensure that the relative width in percentage works.
msg39159 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-21.11:28:14
In Sao.View.resize, we have a trick to use fixed layout and than switch back to auto in order to allow the grow of the cell content.
So this means that the width of the column may vary a little bit during the lifetime of a treeview. This can be awkward for the user experience. And it has performance issue because the browse needs to recompute the display of the table (which can be large).
We have to use this trick because we do not set a width to each column.
So I propose to set a col for each field with a width in percentage. As far as I could see the percentage does not need to sum to 100%, so we can use it as the deprecated width attribute of col: 1*.
As the column will have a fixed width, the content may overflow so I propose to put a title to let the user get the full text of the cell.

In the same way, the button in treeview has padding and border that makes them bigger than the other cell. So we should remove those to keep the row similar.
And when a cell is edited, the input widget also has padding which is added to the existing cell padding. This should also remove to avoid row grows.
History
Date User Action Args
2018-03-22 21:49:51roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39233
2018-03-22 20:19:01reviewbotsetmessages: + msg39232
2018-03-21 15:15:55reviewbotsetmessages: + msg39181
2018-03-21 15:13:54cedsetmessages: + msg39180
2018-03-21 14:30:40nicoesetnosy: + nicoe
messages: + msg39177
2018-03-21 11:49:19reviewbotsetnosy: + reviewbot
messages: + msg39164
2018-03-21 11:31:45cedsetstatus: in-progress -> testing
reviews: 37111002
messages: + msg39160
keyword: + review
2018-03-21 11:28:14cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)