Tryton - Issues

 

Issue7181

Title Hide badge when count is zero
Priority feature Status resolved
Superseder Nosy List albertca, ced, reviewbot, roundup-bot
Type feature request Components sao
Assigned To ced Keywords review
Reviews 39201002
View: 39201002

Created on 2018-02-28.18:18:06 by albertca, last changed by roundup-bot.

Messages
New changeset bc928d86ef39 by C├ędric Krier in branch 'default':
Hide badge when zero and use absolute position
http://hg.tryton.org/sao/rev/bc928d86ef39
review39201002 updated at https://codereview.tryton.org/39201002/#ps20001
msg39357 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-25.15:02:05
Indeed issue7251 went in the opposite direction to set a fixed width for the badge to avoid jump in button position.
But the badge could be floating so this way we could hide it without changing the size of toolbar. And as issue7251 adds tooltip with the number, we can non display the 0.
So I updated the review to make badge floating and limit to 99+.
review39201002 updated at https://codereview.tryton.org/39201002/#ps1
msg38675 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-28.18:22:46
I do not agree, the badget with the value zero show that the information has been retrieved.
msg38674 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2018-02-28.18:18:05
When the number of attachments or notes to read is zero, the badge is not really necessary. And takes too much user attention for really no information.

So I propose to hide it when quantity is zero.
History
Date User Action Args
2018-03-25 23:52:53roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39367
2018-03-25 15:17:50reviewbotsetmessages: + msg39358
2018-03-25 15:02:06cedsetstatus: chatting -> testing
assignedto: ced
messages: + msg39357
2018-02-28 18:23:30reviewbotsetnosy: + reviewbot
messages: + msg38678
2018-02-28 18:22:46cedsetstatus: unread -> chatting
nosy: + ced
messages: + msg38675
2018-02-28 18:18:06albertcacreate

Showing 10 items. Show all history (warning: this could be VERY long)