Tryton - Issues

 

Issue7144

Title Context incoherence
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components proteus, purchase_request_quotation, purchase_requisition
Assigned To ced Keywords review
Reviews 38101002,44831002,44251003
View: 38101002, 44831002, 44251003

Created on 2018-02-16.12:14:08 by ced, last changed by roundup-bot.

Messages
New changeset e2155169ab6e by Cédric Krier in branch 'default':
Do not modify proteus config context
http://hg.tryton.org/modules/production/rev/e2155169ab6e
New changeset 8715dd3aa2fa by Cédric Krier in branch 'default':
Re-use employee instance and append new Party instance
http://hg.tryton.org/modules/purchase_request_quotation/rev/8715dd3aa2fa
New changeset d2595bc8b56f by Cédric Krier in branch 'default':
Re-use employee instance instead of reading from user
http://hg.tryton.org/modules/purchase_requisition/rev/d2595bc8b56f
New changeset 9ed64cecb732 by Cédric Krier in branch 'default':
Always use the context and config of the instance
http://hg.tryton.org/proteus/rev/9ed64cecb732
review38101002 updated at https://codereview.tryton.org/38101002/#ps150001
msg39507 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-03-28.18:19:06
Ready for testing.
review38101002 updated at https://codereview.tryton.org/38101002/#ps130001
review38101002 updated at https://codereview.tryton.org/38101002/#ps120001
review44251003 updated at https://codereview.tryton.org/44251003/#ps1
review44831002 updated at https://codereview.tryton.org/44831002/#ps1
review38101002 updated at https://codereview.tryton.org/38101002/#ps80001
review38101002 updated at https://codereview.tryton.org/38101002/#ps60001
review38101002 updated at https://codereview.tryton.org/38101002/#ps2
review38101002 updated at https://codereview.tryton.org/38101002/#ps40001
review38101002 updated at https://codereview.tryton.org/38101002/#ps20001
New review38101002 at https://codereview.tryton.org/38101002/#ps1
msg38408 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-02-16.12:14:08
There is an incoherence in the context management in proteus.
Until r 4a754a2b76c3, the context was always taken from the _config attribute of the Model. So now, we have two place where the context is taken and they may be different.
I think the context management should be more coherent and an instance should always use the same context during its all life. This include the related record instantiated by xxx2xxx fields.
History
Date User Action Args
2018-04-14 17:17:06roundup-botsetmessages: + msg39998
2018-03-30 18:12:53roundup-botsetmessages: + msg39566
2018-03-30 18:12:05roundup-botsetmessages: + msg39565
2018-03-30 18:11:20roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg39564
2018-03-28 18:44:16reviewbotsetmessages: + msg39508
2018-03-28 18:19:07cedsetstatus: in-progress -> testing
messages: + msg39507
2018-03-28 18:12:46reviewbotsetmessages: + msg39506
2018-03-28 17:10:20reviewbotsetmessages: + msg39505
2018-03-28 17:09:59reviewbotsetmessages: + msg39503
2018-03-28 16:40:17cedsetreviews: 38101002,44831002 -> 38101002,44831002,44251003
component: + purchase_request_quotation

Showing 10 items. Show all history (warning: this could be VERY long)